Skip to content

refactor(cms): for-lawyers-page-type #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alcercu merged 1 commit into from
Jan 21, 2025
Merged

refactor(cms): for-lawyers-page-type #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...section/content-types/for-lawyers-page-dispute-resolution-with-kleros-section/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,9 @@
},
"thirdSubtitle": {
"type": "text"
},
"subtitle": {
"type": "text"
}
}
}
10 changes: 5 additions & 5 deletions ...s-enterprise-section/content-types/for-lawyers-page-kleros-enterprise-section/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,11 +50,6 @@
"audios"
]
},
"articleLink": {
"type": "relation",
"relation": "oneToOne",
"target": "api::link.link"
},
"table": {
"type": "component",
"repeatable": false,
Expand All @@ -64,6 +59,11 @@
"type": "component",
"repeatable": false,
"component": "content.highlight-text"
},
"arrowLink": {
"type": "component",
"repeatable": false,
"component": "content.button-link"
Comment on lines +63 to +66
Copy link
Contributor

@coderabbitai coderabbitai bot Jan 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Breaking Change: Component exists but migration needed

The content.button-link component exists and is already used by other components in the codebase. While the component integration is valid, this remains a breaking change that requires:

  1. Data migration for existing articleLink relation data to the new arrowLink component structure
  2. Frontend code updates to handle the new component-based approach instead of the relation
🔗 Analysis chain

Breaking Change: Verify data migration strategy.

The replacement of articleLink (relation) with arrowLink (component) is a breaking change that requires:

  1. Data migration strategy for existing content
  2. Updates to any frontend code relying on the previous relation structure

Let's verify the existence of the required component:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check if the button-link component exists in the content components
rg -g "*.json" -l "button-link" ./cms-backend/src/components/content/

Length of output: 172

Script:

#!/bin/bash
# Check content of found files and search for component definition
echo "=== Content of cta-card.json ==="
cat ./cms-backend/src/components/content/cta-card.json
echo -e "\n=== Content of link-card.json ==="
cat ./cms-backend/src/components/content/link-card.json

# Search for button-link component definition
echo -e "\n=== Searching for button-link component definition ==="
rg -g "*.json" -A 5 '"collectionName": "components_content_button_links"' ./cms-backend/src/components/

Length of output: 2116

}
}
}
3 changes: 2 additions & 1 deletion cms-backend/types/generated/contentTypes.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1334,6 +1334,7 @@ export interface ApiForLawyersPageDisputeResolutionWithKlerosSectionForLawyersPa
publishedAt: Schema.Attribute.DateTime;
secondHeader: Schema.Attribute.String;
secondSubtitle: Schema.Attribute.Text;
subtitle: Schema.Attribute.Text;
thirdHeader: Schema.Attribute.String;
thirdSubtitle: Schema.Attribute.Text;
updatedAt: Schema.Attribute.DateTime;
Expand Down Expand Up @@ -1390,7 +1391,7 @@ export interface ApiForLawyersPageKlerosEnterpriseSectionForLawyersPageKlerosEnt
draftAndPublish: true;
};
attributes: {
articleLink: Schema.Attribute.Relation<'oneToOne', 'api::link.link'>;
arrowLink: Schema.Attribute.Component<'content.button-link', false>;
cards: Schema.Attribute.Component<'content.cta-card', true>;
createdAt: Schema.Attribute.DateTime;
createdBy: Schema.Attribute.Relation<'oneToOne', 'admin::user'> &
Expand Down