git source should have an optional "src_dir" setting

[squee1945]

When specifying a git source, e.g.,

  source:
    git:
      url: https://github.com/mchmarny/rester-tester.git
      branch: master

It seems that we will need to allow the user to (optionally) identify the root of the source to be built, e.g.,

  source:
    git:
      url: https://github.com/mchmarny/rester-tester.git
      branch: master
      src_dir: webapp/src

A git repo may contain any number of supporting folders and the required build key file (e.g., pom.xml, package.json, build.gradle) may not be housed at the very top level.

When fetching the contents of this repo, only the src_dir contents should be placed in the build workspace. (Perhaps there is some git optimization that allows only this sub-folder to be fetched in the first place.)

[mattmoor]

@imjasonh GCB has logic like this, but it actually fetches the whole thing and changes the default working directory that's used in the steps to /workspace/{src_dir}.

[imjasonh]

Some git hosts support partial clones: https://github.com/git/git/blob/master/Documentation/technical/partial-clone.txt

For purposes of prioritizing, is there a motivating client that needs this soon, or is this a nice-to-have that we expect someone to need eventually?

[squee1945]

No known client right now. Just anticipating a future need.

[evankanderson]

This would be handy for the samples in elafros/elafros, for example. (Right now they all point to separate github repos, which makes patching any of the code in the samples a pain.)

[rgregg]

This came up again, in the context of the samples. We're using Docker instead of Build CRD in the instructions because we don't want to fragment the samples into separate repos. If we can fix this, we can update all the samples to use the on-cluster Build.

[evankanderson]

/assign evankanderson

…

On Tue, Jul 3, 2018 at 8:37 AM Ryan Gregg ***@***.***> wrote: This came up again, in the context of the samples. We're using Docker instead of Build CRD in the instructions because we don't want to fragment the samples into separate repos. If we can fix this, we can update all the samples to use the on-cluster Build. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#91 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHlyN0pvQMKnySu8-Ivsu-vd2SSU45OHks5uC4_SgaJpZM4S0hi-> .

-- Evan Anderson <argent@google.com>