Delete unused testdata directory, useless test, unused test methods#467
Delete unused testdata directory, useless test, unused test methods#467knative-prow-robot merged 4 commits intoknative:masterfrom
Conversation
knative-prow-robot
left a comment
knative-prow-robot
left a comment
There was a problem hiding this comment.
@imjasonh: 0 warnings.
Details
In response to this:
Proposed Changes
- Remove
TestParsingfrombuild_types_test.gowhich for-some-reason tested that a GCB build config could be (partially...?) parsed into a Build CRD. It only tested it with one of the testdata YAMLs anyway, and nobody cares about that feature.- Remove
pkg/apis/build/v1alpha1/testdata/**which was unused except for that test ☝️- Remove
pkg/buildtest/{data,yaml}.gowhich were unused except for that test ☝️- Remove
pkg/buildtest/json.gowhich was just entirely unused.After this change, the only thing in
pkg/buildtestiswait.gowhich is only used bypkg/builder/cluster/builder_test.go, which will also be deleted in #464Release Note
NONE
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
|
|
||
| // dataAs interprets the YAML contents of the file at the given path as the | ||
| // given type. | ||
| func dataAs(relpath string, obj interface{}) error { |
There was a problem hiding this comment.
Where is this function being used?
There was a problem hiding this comment.
Oops, nothing uses it anymore. Originally this PR was to move buildtest.DataAs into this test package, but then I realized we didn't need it at all, so we can just get rid of all of it! 🗑
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ImJasonH, shashwathi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…native#467) * Remove unused testdata directory, useless test, unused test methods * update deps * remove dataAs et al * update deps
…native#467) * Remove unused testdata directory, useless test, unused test methods * update deps * remove dataAs et al * update deps
…native#467) * Remove unused testdata directory, useless test, unused test methods * update deps * remove dataAs et al * update deps
3 participants
Proposed Changes
TestParsingfrombuild_types_test.gowhich for-some-reason tested that a GCB build config could be (partially...?) parsed into a Build CRD. It only tested it with one of the testdata YAMLs anyway, and nobody cares about that feature.pkg/apis/build/v1alpha1/testdata/**which was unused except for that test ☝️pkg/buildtest/{data,yaml}.gowhich were unused except for that test ☝️pkg/buildtest/json.gowhich was just entirely unused.After this change, the only thing in
pkg/buildtestiswait.gowhich is only used bypkg/builder/cluster/builder_test.go, which will also be deleted in #464Release Note