This repository was archived by the owner on Sep 5, 2019. It is now read-only.
Merged
Conversation
This is the "build" version of knative/serving#3332 We're seeing OOM issues at the Node level when we don't set the limit. This will allow the pod to restart gracefully w/o taking down the entire node. I'm not stuck on the specific value so we can pick a different one. Signed-off-by: Doug Davis <dug@us.ibm.com>
Contributor
|
/test pull-knative-build-integration-tests |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: duglin, ImJasonH The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
/lgtm |
vdemeester
pushed a commit
to vdemeester/knative-build
that referenced
this pull request
Apr 3, 2019
* Set memory limits This is the "build" version of knative/serving#3332 We're seeing OOM issues at the Node level when we don't set the limit. This will allow the pod to restart gracefully w/o taking down the entire node. I'm not stuck on the specific value so we can pick a different one. Signed-off-by: Doug Davis <dug@us.ibm.com> * Fix indentation
vdemeester
pushed a commit
to vdemeester/knative-build
that referenced
this pull request
Apr 3, 2019
* Set memory limits This is the "build" version of knative/serving#3332 We're seeing OOM issues at the Node level when we don't set the limit. This will allow the pod to restart gracefully w/o taking down the entire node. I'm not stuck on the specific value so we can pick a different one. Signed-off-by: Doug Davis <dug@us.ibm.com> * Fix indentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the "build" version of knative/serving#3332
We're seeing OOM issues at the Node level when we don't set the limit.
This will allow the pod to restart gracefully w/o taking down the entire node.
I'm not stuck on the specific value so we can pick a different one.
Signed-off-by: Doug Davis dug@us.ibm.com
Release Note
/lint