docs: Remove --save from npm install
#1206
Conversation
|
Hi @grant. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
knative-prow-robot
added
needs-ok-to-test
|
/ok-to-test |
knative-prow-robot
added
ok-to-test
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grant, samodell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Please unsubscribe me from this thread.
Sameer Madamaiah
… On Apr 18, 2019, at 6:50 PM, Grant Timmerman ***@***.***> wrote:
Proposed Changes
Remove --save from npm install script.
See https://stackoverflow.com/a/19578808
You can view, comment on, or merge this pull request online at:
#1206
Commit Summary
docs: Remove `--save` from `npm install`
File Changes
M docs/serving/samples/hello-world/helloworld-nodejs/README.md (2)
Patch Links:
https://github.com/knative/docs/pull/1206.patch
https://github.com/knative/docs/pull/1206.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
* Fix typo Knatve -> Knative (#1196) Signed-off-by: xichengliudui <1693291525@qq.com> * docs: Remove `--save` from `npm install` (#1206) See https://stackoverflow.com/a/19578808 * serving/samples/helloworld-php: render newline (#1224) * serving/samples/helloworld-php: render newline * Double quotes in README too * Fix a couple broken links to removed samples. (#1242) * Remove references to Istio yamls attached to releases. (#1243) In 0.6 we will stop shipping Istio yamls, as we are not in the business of redistributing Istio (incl. supporting these yamls). In preparation for that, this change makes a few changes: 1. Update things to point to the 0.5.2 release 1. Point to our in-tree Istio files (which is what we were attaching) 1. For GKE, direct users to the Istio addon instead. 1. For GKE, add a pointer to CR-GKE (if folks wanted hosted). This is a half-measure to avoid things breaking. We need a page that points folks to the Istio docs, and calls out any specialized instructions for what Knative needs. * Fix command line to extract LATEST_HOSTNAME (#1258) * address wrong manifest in gcppubsub sample (#1273) * fix broken demo (#1277)
5 participants
Proposed Changes
--savefromnpm installscript.See https://stackoverflow.com/a/19578808