fix broken demo #1277
Merged
fix broken demo #1277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
the
size/XS
Member
Author
|
@RichieEscarez mind checking here ? |
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew, samodell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
samodell
pushed a commit
to samodell/docs
that referenced
this pull request
May 10, 2019
Merged
knative-prow-robot
pushed a commit
that referenced
this pull request
May 10, 2019
* Fix typo Knatve -> Knative (#1196) Signed-off-by: xichengliudui <1693291525@qq.com> * docs: Remove `--save` from `npm install` (#1206) See https://stackoverflow.com/a/19578808 * serving/samples/helloworld-php: render newline (#1224) * serving/samples/helloworld-php: render newline * Double quotes in README too * Fix a couple broken links to removed samples. (#1242) * Remove references to Istio yamls attached to releases. (#1243) In 0.6 we will stop shipping Istio yamls, as we are not in the business of redistributing Istio (incl. supporting these yamls). In preparation for that, this change makes a few changes: 1. Update things to point to the 0.5.2 release 1. Point to our in-tree Istio files (which is what we were attaching) 1. For GKE, direct users to the Istio addon instead. 1. For GKE, add a pointer to CR-GKE (if folks wanted hosted). This is a half-measure to avoid things breaking. We need a page that points folks to the Istio docs, and calls out any specialized instructions for what Knative needs. * Fix command line to extract LATEST_HOSTNAME (#1258) * address wrong manifest in gcppubsub sample (#1273) * fix broken demo (#1277)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mattmoor the service is call
event-display