Skip to content

Fix command line to extract LATEST_HOSTNAME #1258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 6, 2019
Merged

Fix command line to extract LATEST_HOSTNAME #1258

merged 1 commit into from
May 6, 2019

Conversation

@wtam2018
Copy link
Contributor

@wtam2018 wtam2018 commented May 1, 2019 •
edited
Loading

Update the command in README to correctly extract latest_hostname from target Knative Service json output.

Proposed Changes

  • pick the right k service ("stock-service-example")
  • look up with right field ("name")

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label May 1, 2019
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented May 1, 2019

Hi @wtam2018. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 1, 2019
@sebgoa
Copy link
Contributor

sebgoa commented May 6, 2019

/ok-to-test
/lgtm

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 6, 2019
@samodell
Copy link
Contributor

samodell commented May 6, 2019

/approve

@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented May 6, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: samodell, wtam2018

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 8d2451e into knative:master May 6, 2019
samodell pushed a commit to samodell/docs that referenced this pull request May 10, 2019
@wtam2018 @samodell
Fix command line to extract LATEST_HOSTNAME (knative#1258)
1637e57
@samodell samodell mentioned this pull request May 10, 2019
Merged
knative-prow-robot pushed a commit that referenced this pull request May 10, 2019
@samodell @knative-prow-robot
Cherry-pick batch (#1306)
4d89fdc 
* Fix typo Knatve -> Knative (#1196)

Signed-off-by: xichengliudui <1693291525@qq.com>

* docs: Remove `--save` from `npm install` (#1206)

See https://stackoverflow.com/a/19578808

* serving/samples/helloworld-php: render newline (#1224)

* serving/samples/helloworld-php: render newline

* Double quotes in README too

* Fix a couple broken links to removed samples. (#1242)

* Remove references to Istio yamls attached to releases. (#1243)

In 0.6 we will stop shipping Istio yamls, as we are not in the business of
redistributing Istio (incl. supporting these yamls).  In preparation for that,
this change makes a few changes:
1. Update things to point to the 0.5.2 release
1. Point to our in-tree Istio files (which is what we were attaching)
1. For GKE, direct users to the Istio addon instead.
1. For GKE, add a pointer to CR-GKE (if folks wanted hosted).

This is a half-measure to avoid things breaking.  We need a page that points
folks to the Istio docs, and calls out any specialized instructions for
what Knative needs.

* Fix command line to extract LATEST_HOSTNAME (#1258)

* address wrong manifest in gcppubsub sample (#1273)

* fix broken demo (#1277)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gyliu513 gyliu513 Awaiting requested review from gyliu513

@samodell samodell Awaiting requested review from samodell

Assignees

@sebgoa sebgoa

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wtam2018 @knative-prow-robot @sebgoa @samodell @googlebot