Skip to content

Cherry-pick batch #1306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 10, 2019
Merged

Cherry-pick batch #1306

merged 8 commits into from
May 10, 2019

Conversation

@samodell
Copy link
Contributor

@samodell samodell commented May 10, 2019

xichengliudui and others added 8 commits May 10, 2019 15:07
@xichengliudui @samodell
Fix typo Knatve -> Knative (knative#1196)
a12a928 
Signed-off-by: xichengliudui <1693291525@qq.com>
@grant @samodell
docs: Remove --save from npm install (knative#1206)
5f52b08 
See https://stackoverflow.com/a/19578808
@grayside @samodell
serving/samples/helloworld-php: render newline (knative#1224)
4f80c22 
* serving/samples/helloworld-php: render newline

* Double quotes in README too
@mattmoor @samodell
Fix a couple broken links to removed samples. (knative#1242)
3ca6cb9
@mattmoor @samodell
Remove references to Istio yamls attached to releases. (knative#1243)
e25ea68 
In 0.6 we will stop shipping Istio yamls, as we are not in the business of
redistributing Istio (incl. supporting these yamls).  In preparation for that,
this change makes a few changes:
1. Update things to point to the 0.5.2 release
1. Point to our in-tree Istio files (which is what we were attaching)
1. For GKE, direct users to the Istio addon instead.
1. For GKE, add a pointer to CR-GKE (if folks wanted hosted).

This is a half-measure to avoid things breaking.  We need a page that points
folks to the Istio docs, and calls out any specialized instructions for
what Knative needs.
@wtam2018 @samodell
Fix command line to extract LATEST_HOSTNAME (knative#1258)
1637e57
@sebgoa @samodell
address wrong manifest in gcppubsub sample (knative#1273)
6a126cb
@matzew @samodell
fix broken demo (knative#1277)
2480ca7
@samodell samodell requested a review from RichieEscarez May 10, 2019 22:20
@googlebot
Copy link

googlebot commented May 10, 2019

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no Indicates the PR's author has not signed the CLA. label May 10, 2019
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 10, 2019
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented May 10, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: samodell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@samodell
Copy link
Contributor Author

samodell commented May 10, 2019

Manually setting the CLA label, since these commits have already been submitted to Knative by their respective authors in their original PRs.

@samodell samodell added cla: yes Indicates the PR's author has signed the CLA. and removed cla: no Indicates the PR's author has not signed the CLA. labels May 10, 2019
@googlebot
Copy link

googlebot commented May 10, 2019

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@RichieEscarez RichieEscarez added the lgtm Indicates that a PR is ready to be merged. label May 10, 2019
@knative-prow-robot knative-prow-robot merged commit 4d89fdc into knative:release-0.5 May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RichieEscarez RichieEscarez Awaiting requested review from RichieEscarez

@gyliu513 gyliu513 Awaiting requested review from gyliu513

Assignees

No one assigned

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.