Skip to content

Conversation

@RichieEscarez
Copy link
Contributor

remove outdated content

re: #1859

@RichieEscarez RichieEscarez requested a review from dgerd October 31, 2019 00:35
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 31, 2019
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved labels Oct 31, 2019
@samodell
Copy link
Contributor

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2019
@samodell
Copy link
Contributor

/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RichieEscarez, samodell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [RichieEscarez,samodell]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 06881ad into knative:master Oct 31, 2019
nachocano pushed a commit to nachocano/docs that referenced this pull request Nov 3, 2019
* invalid since v0.8.1

fix for knative#1859

* remove references to the invalid topic
knative-prow-robot pushed a commit that referenced this pull request Nov 4, 2019
* invalid since v0.8.1 (#1947)

* invalid since v0.8.1

fix for #1859

* remove references to the invalid topic

* updates (#1950)
knative-prow-robot pushed a commit that referenced this pull request Nov 4, 2019
* invalid since v0.8.1 (#1947)

* invalid since v0.8.1

fix for #1859

* remove references to the invalid topic

* updates (#1950)

* Links to files in pubsub example (#1953)

* updates

* one more fix
@RichieEscarez RichieEscarez deleted the removeoldcontent branch November 18, 2019 19:43
nachocano pushed a commit to nachocano/docs that referenced this pull request Feb 14, 2020
* invalid since v0.8.1

fix for knative#1859

* remove references to the invalid topic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants