Skip to content

Conversation

@nachocano
Copy link
Contributor

Proposed Changes

  • Adding links to the example files otherwise they are not seen in the knative.dev website

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 1, 2019
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 1, 2019
@nachocano
Copy link
Contributor Author

/cherrypick-0.10

@nachocano
Copy link
Contributor Author

/assign @vaikas-google

@vaikas
Copy link
Contributor

vaikas commented Nov 1, 2019

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 1, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nachocano, vaikas-google

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 51b878d into knative:master Nov 1, 2019
nachocano added a commit to nachocano/docs that referenced this pull request Nov 4, 2019
knative-prow-robot pushed a commit that referenced this pull request Nov 4, 2019
* invalid since v0.8.1 (#1947)

* invalid since v0.8.1

fix for #1859

* remove references to the invalid topic

* updates (#1950)

* Links to files in pubsub example (#1953)

* updates

* one more fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants