Skip to content

Conversation

@nachocano
Copy link
Contributor

Proposed Changes

  • One more change so that the example links appear in the website...

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 4, 2019
@nachocano
Copy link
Contributor Author

/assign @samodell

@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 4, 2019
@gyliu513
Copy link
Contributor

gyliu513 commented Nov 4, 2019

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2019
@samodell
Copy link
Contributor

samodell commented Nov 4, 2019

/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nachocano, samodell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit de20799 into knative:release-0.10 Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants