Skip to content

Fixing PubSub source example #1950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2019
Merged

Fixing PubSub source example #1950

merged 1 commit into from
Oct 31, 2019

Conversation

@nachocano
Copy link
Contributor

@nachocano nachocano commented Oct 31, 2019 •
edited
Loading

Fixes #1814
Fixes #1905
Fixes #1843
Fixes #1262
Fixes #1885
Helps with #1750

Proposed Changes

  • Updating PubSub source example to use newer knative-gcp stuff.
  • We should later on revisit whether this documentation should lie here or somewhere else. For now, given that this is published in the knative.dev website, I've decided to put it here.
  • Fix old links in others places. Regenerated files...

@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 31, 2019
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 31, 2019
@nachocano
Copy link
Contributor Author

nachocano commented Oct 31, 2019

/assign @vaikas-google
/assign @grantr

@nachocano
Copy link
Contributor Author

nachocano commented Oct 31, 2019 •
edited
Loading

removing cherrypick

@nachocano nachocano mentioned this pull request Oct 31, 2019
Closed
11 tasks
@zouyee
Copy link

zouyee commented Oct 31, 2019

Please squash commits，thanks.

@nachocano
Copy link
Contributor Author

nachocano commented Oct 31, 2019

Please squash commits，thanks.

Done!

@nachocano
Copy link
Contributor Author

nachocano commented Oct 31, 2019

Can we get this in asap. It's critical, many folks cannot use the PubSub source at all due to this outdated docs. Thanks!!!

@vaikas
Copy link
Contributor

vaikas commented Oct 31, 2019

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2019
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Oct 31, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nachocano, vaikas-google

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 02efe26 into knative:master Oct 31, 2019
nachocano added a commit to nachocano/docs that referenced this pull request Nov 3, 2019
@nachocano
updates (knative#1950)
e907ec4
@nachocano nachocano mentioned this pull request Nov 3, 2019
Merged
knative-prow-robot pushed a commit that referenced this pull request Nov 4, 2019
@nachocano @knative-prow-robot
Cherry-picking changes to release 0.10 (#1957)
0beed0f 
* invalid since v0.8.1 (#1947)

* invalid since v0.8.1

fix for #1859

* remove references to the invalid topic

* updates (#1950)
knative-prow-robot pushed a commit that referenced this pull request Nov 4, 2019
@nachocano @knative-prow-robot
PubSub source cherry-pick Release 0.10 (#1959)
de20799 
* invalid since v0.8.1 (#1947)

* invalid since v0.8.1

fix for #1859

* remove references to the invalid topic

* updates (#1950)

* Links to files in pubsub example (#1953)

* updates

* one more fix
@RichieEscarez RichieEscarez mentioned this pull request Nov 9, 2019
Closed
nachocano added a commit to nachocano/docs that referenced this pull request Feb 14, 2020
@nachocano
updates (knative#1950)
ec15b6e
@ekmixon ekmixon mentioned this pull request Jun 23, 2022
Open
@NOUIY NOUIY mentioned this pull request Jun 23, 2022
Closed
This was referenced Jun 24, 2022
Open
Open
@snyk-bot snyk-bot mentioned this pull request Jun 24, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Jul 27, 2022
Closed
This was referenced Oct 5, 2022
Closed
Closed
This was referenced Jun 20, 2023
Open
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carieshmarie carieshmarie Awaiting requested review from carieshmarie

@samodell samodell Awaiting requested review from samodell

Assignees

@grantr grantr

@vaikas vaikas

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

6 participants

@nachocano @zouyee @vaikas @knative-prow-robot @grantr @googlebot