Kourier Installation guide for Knative Serving

[jmprusi]

Proposed Changes

• Adds a new installation guide for Knative with Kourier

Related to: knative/serving#5982

[knative-prow-robot]

Hi @jmprusi. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[samodell]

/ok-to-test

[bbrowning]

Should this reference a tag of Kourier that was tested with this release of Knative?

[jmprusi]

We created a "floating tag": https://github.com/3scale/kourier/blob/v0.3/deploy/kourier-knative.yaml

We will override that tag pointing to the latest v0.3.x release. We follow semver, so any breaking change will trigger an increase of the major version, so it should work. wdyt?

[samodell]

Thanks for adding this guide! A few suggestions before we can get it merged in.

[samodell]

We just got automatic numbering to render properly on the website! Lists that are indented at the same level will auto-number for you:

1. one

1. two

1. three

becomes

1. one

2. two

3. three

[samodell]

(so the fix here is just to start every numbered list item with "1.")

[samodell]

Suggested change

	Get this external IP address with:
	To get the external IP address, use the following command:

[samodell]

You'll need to add a line break after "to:"; all code blocks need to have white space before and after.

[samodell]

Above comment about list numbering applies here as well.

[samodell]

We're doing the headings in alphabetical order; could you put Kourier after the "Installing Knative with Istio" heading?

[samodell]

Suggested change

	$ kubectl get svc kourier -n knative-serving
	kubectl get svc kourier -n knative-serving

[samodell]

For consistency with the rest of the Knative docs, omit the command line prompt.

[RichieEscarez]

Can we fix the filename to use only lowercase? The use of capitals is non-standard and breaks local testing (unlike our hosting server on knative.dev, the localhost does not automatically change all filenames to lowercase and therefore all install guides show as 404 when running the localbuild.sh script).

Change: Knative-with-Kourier.md

To: knative-with-kourier.md

For example, this is what the hosted URL will be (therefore the filename should match and also be lowercase):
https://knative.dev/docs/install/knative-with-kourier/

[jmprusi]

Thanks for the review @samodell @RichieEscarez.

Sorry for the delay I've been on some much-needed vacations. Updated the PR with all the review comments fixed :)

[lesv]

Should this be: https://raw.githubusercontent.com/knative/serving/master/third_party/kourier-latest/kourier.yaml ??

[lesv]

diff between the two pages.

25c25
<     - name: http2
---
>     - name: http
33,47d32
< apiVersion: v1
< kind: Service
< metadata:
<   name: kourier-tls
<   namespace: kourier-system
< spec:
<   ports:
<     - name: http2
<       port: 443
<       protocol: TCP
<       targetPort: 8443
<   selector:
<     app: 3scale-kourier-gateway
<   type: LoadBalancer
< ---
87,93c72,73
<             httpGet:
<               httpHeaders:
<                 - name: Host
<                   value: internalkourier
<               path: /__internalkouriersnapshot
<               port: 8081
<               scheme: HTTP
---
>             exec:
>               command: ['ash','-c','(printf "GET /__internalkouriersnapshot HTTP/1.1\r\nHost: internalkourier\r\n\r\n"; sleep 1) | nc -n localhost 8081 | grep "HTTP/1.1 200 OK"']
129c109
<         - image: quay.io/3scale/kourier:v0.3.5
---
>         - image: quay.io/3scale/kourier:v0.3.4
202c182,197
<   type: ClusterIP
---
>   type: LoadBalancer
> ---
> apiVersion: v1
> kind: Service
> metadata:
>   name: kourier-external
>   namespace: kourier-system
> spec:
>   ports:
>     - name: http2
>       port: 80
>       protocol: TCP
>       targetPort: 8080
>   selector:
>     app: 3scale-kourier-gateway
>   type: LoadBalancer
216c211
<   type: ClusterIP
---
>   type: LoadBalancer
224a220,225
>     admin:
>       access_log_path: /tmp/test
>       address:
>         socket_address:
>           address: 0.0.0.0
>           port_value: 19000
239,267d239
<       listeners:
<         - name: stats_listener
<           address:
<             socket_address:
<               address: 0.0.0.0
<               port_value: 9000
<           filter_chains:
<             - filters:
<                 - name: envoy.http_connection_manager
<                   config:
<                     stat_prefix: stats_server
<                     route_config:
<                       virtual_hosts:
<                         - name: admin_interface
<                           domains:
<                             - "*"
<                           routes:
<                             - match:
<                                 safe_regex:
<                                   google_re2: {}
<                                   regex: '/(certs|stats(/prometheus)?|server_info|clusters|listeners|ready)?'
<                                 headers:
<                                   - name: ':method'
<                                     exact_match: GET
<                               route:
<                                 cluster: service_stats
<                     http_filters:
<                       - name: envoy.router
<                         config: {}
269,271c241
<         - name: service_stats
<           connect_timeout: 0.250s
<           type: static
---
>         - connect_timeout: 0.2s
273c243
<             cluster_name: service_stats
---
>             cluster_name: xds_cluster
275,285c245,250
<               lb_endpoints:
<                 endpoint:
<                   address:
<                     pipe:
<                       path: /tmp/envoy.admin
<         - name: xds_cluster
<           connect_timeout: 1s
<           hosts:
<             - socket_address:
<                 address: "kourier-control"
<                 port_value: 18000
---
>               - lb_endpoints:
>                 - endpoint:
>                     address:
>                       socket_address:
>                         address: kourier-control
>                         port_value: 18000
286a252,255
>           upstream_connection_options:
>             tcp_keepalive: {}
>           lb_policy: ROUND_ROBIN
>           name: xds_cluster
288,292d256
<     admin:
<       access_log_path: "/dev/stdout"
<       address:
<         pipe:
<           path: /tmp/envoy.admin

[lesv]

Ah - I see, your version is later. @samodell may wish to inquire of davidor@ who create the one in knative/serving.

[samodell]

/lgtm
/approve

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmprusi, samodell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [samodell]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment