Updating to LATEST for Kafka Channel/Source #2121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
the
size/XS
knative-prow-robot
added
size/S
abrennan89
approved these changes
Jan 22, 2020
Contributor
abrennan89
left a comment
abrennan89
left a comment
There was a problem hiding this comment.
Excellent, thanks so much for addressing this @matzew
Contributor
|
/assign @vaikas |
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abrennan89, matzew, samodell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
samodell
pushed a commit
to samodell/docs
that referenced
this pull request
Jan 23, 2020
* Updating to LATEST for Kafka Channel/Source * Switching the values to 1 replica, but 3 partitions
knative-prow-robot
pushed a commit
that referenced
this pull request
Jan 23, 2020
* Kourier Installation guide for Knative Serving (#2006) * Adds a new guide describing how to install knative with kourier * Links the knative with kourier installation guide in the main README file * Use kourier-system instead of knative-serving when getting kourier IP * Install Kourier using the included yaml in third_party * Update the Auto TLS instruction (#2083) * initial version of auto tls instruction * Update auto-tls doc to mention namespace cert feature and http01 challenge feature * address comments * fix format * address comments * Format cmd for easy reading© (#2120) * Updating to LATEST for Kafka Channel/Source (#2121) * Updating to LATEST for Kafka Channel/Source * Switching the values to 1 replica, but 3 partitions Co-authored-by: Joaquim Moreno Prusi <jmprusi@keepalive.io> Co-authored-by: Zhimin Xiang <zhiminx@google.com> Co-authored-by: 赤月 <974226358@qq.com> Co-authored-by: Matthias Wessendorf <mwessend@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The doc should not go with a specific version, they should use LATEST release.
/cc @abrennan89