Skip to content

Conversation

@samodell
Copy link
Contributor

Cherry-pick batch for January 23rd. (From this point on, cherry-picks will be done in a batch weekly on Thursday.)

Adding cla: yes label because all these commits were previously submitted to master.

jmprusi and others added 4 commits January 23, 2020 09:37
* Adds a new guide describing how to install knative with kourier

* Links the knative with kourier installation guide in the main README file

* Use kourier-system instead of knative-serving when getting kourier IP

* Install Kourier using the included yaml in third_party
* initial version of auto tls instruction

* Update auto-tls doc to mention namespace cert feature and http01 challenge feature

* address comments

* fix format

* address comments
* Updating to LATEST for Kafka Channel/Source

* Switching the values to 1 replica, but 3 partitions
@samodell samodell added the cla: yes Indicates the PR's author has signed the CLA. label Jan 23, 2020
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no Indicates the PR's author has not signed the CLA. and removed cla: yes Indicates the PR's author has signed the CLA. labels Jan 23, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: samodell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added approved size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 23, 2020
@samodell samodell added cla: yes Indicates the PR's author has signed the CLA. and removed cla: no Indicates the PR's author has not signed the CLA. labels Jan 23, 2020
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@RichieEscarez RichieEscarez added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2020
@knative-prow-robot knative-prow-robot merged commit 3dfd2bc into knative:release-0.12 Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants