Skip to content

Format cmd for easy reading&copy #2120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 22, 2020
Merged

Format cmd for easy reading&copy #2120

merged 1 commit into from
Jan 22, 2020

Conversation

@zwOvO
Copy link
Contributor

@zwOvO zwOvO commented Jan 22, 2020

Fixes #issue-number

Proposed Changes

  • Add newline

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jan 22, 2020
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Jan 22, 2020

Hi @zwOvO. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 22, 2020
@gyliu513
Copy link
Contributor

gyliu513 commented Jan 22, 2020

/ok-to-test
/lgtm

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 22, 2020
@samodell
Copy link
Contributor

samodell commented Jan 22, 2020

Thanks, @zwOvO !

/approve

@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Jan 22, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: samodell, zwOvO

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit d704f53 into knative:master Jan 22, 2020
samodell pushed a commit to samodell/docs that referenced this pull request Jan 23, 2020
@zwOvO @samodell
Format cmd for easy reading&copy (knative#2120)
31c1ac0
knative-prow-robot pushed a commit that referenced this pull request Jan 23, 2020
@samodell @jmprusi
@zwOvO @matzew @knative-prow-robot
Release 0.12 (#2128)
3dfd2bc 
* Kourier Installation guide for Knative Serving (#2006)

* Adds a new guide describing how to install knative with kourier

* Links the knative with kourier installation guide in the main README file

* Use kourier-system instead of knative-serving when getting kourier IP

* Install Kourier using the included yaml in third_party

* Update the Auto TLS instruction (#2083)

* initial version of auto tls instruction

* Update auto-tls doc to mention namespace cert feature and http01 challenge feature

* address comments

* fix format

* address comments

* Format cmd for easy reading&copy (#2120)

* Updating to LATEST for Kafka Channel/Source (#2121)

* Updating to LATEST for Kafka Channel/Source

* Switching the values to 1 replica, but 3 partitions

Co-authored-by: Joaquim Moreno Prusi <jmprusi@keepalive.io>
Co-authored-by: Zhimin Xiang <zhiminx@google.com>
Co-authored-by: 赤月 <974226358@qq.com>
Co-authored-by: Matthias Wessendorf <mwessend@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abrennan89 abrennan89 Awaiting requested review from abrennan89

@samodell samodell Awaiting requested review from samodell

Assignees

@gyliu513 gyliu513

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zwOvO @knative-prow-robot @gyliu513 @samodell @googlebot