-
Notifications
You must be signed in to change notification settings - Fork 630
Add constants for supported Eventing labels and annotations #3321
Copy link
Copy link
Closed
Labels
area/apikind/cleanupCategorizes issue or PR as related to cleaning up code, process, or technical debt.Categorizes issue or PR as related to cleaning up code, process, or technical debt.kind/feature-requestkind/good-first-issueDenotes an issue ready for a new contributor.Denotes an issue ready for a new contributor.priority/important-longtermImportant over the long term, but may not be staffed and/or may need multiple releases to complete.Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Description
Metadata
Metadata
Assignees
Labels
area/apikind/cleanupCategorizes issue or PR as related to cleaning up code, process, or technical debt.Categorizes issue or PR as related to cleaning up code, process, or technical debt.kind/feature-requestkind/good-first-issueDenotes an issue ready for a new contributor.Denotes an issue ready for a new contributor.priority/important-longtermImportant over the long term, but may not be staffed and/or may need multiple releases to complete.Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Problem
We don't have any constant set for common labels and annotations such as
This can lead to repetition in the code base, especially in projects that use Knative as a dependency.
Persona:
Contributors
Exit Criteria
Supported labels and annotations are defined as public constants inside
pkg/apis/(messaging|eventing|...)Example: https://github.com/knative/serving/blob/3b5be63/pkg/apis/serving/register.go
Time Estimate (optional):
How many developer-days do you think this may take to resolve?
1/2
Ref. knative/pkg#1407