Skip to content

Using constants#3397

Merged
knative-prow-robot merged 1 commit into
knative:masterfrom
matzew:use_constant
Jun 24, 2020
Merged

Using constants#3397
knative-prow-robot merged 1 commit into
knative:masterfrom
matzew:use_constant

Conversation

@matzew
Copy link
Copy Markdown
Member

@matzew matzew commented Jun 24, 2020

Signed-off-by: Matthias Wessendorf mwessend@redhat.com

Fixes #3321

Proposed Changes

  • using constants

Release Note


Docs

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 24, 2020
@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/test-and-release Test infrastructure, tests or release labels Jun 24, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2020
@lionelvillard
Copy link
Copy Markdown
Contributor

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2020
@knative-prow-robot knative-prow-robot merged commit 4ac2f3a into knative:master Jun 24, 2020
lberk pushed a commit to lberk/eventing that referenced this pull request Jun 26, 2020
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add constants for supported Eventing labels and annotations

4 participants