Skip to content

test: merge overlapping TLS and OIDC rekt e2e suites - #9257

Open
VedantMadane wants to merge 1 commit into
knative:mainfrom
VedantMadane:merge-tls-oidc-e2e-7638
Open

test: merge overlapping TLS and OIDC rekt e2e suites#9257
VedantMadane wants to merge 1 commit into
knative:mainfrom
VedantMadane:merge-tls-oidc-e2e-7638

Conversation

@VedantMadane

Copy link
Copy Markdown

Fixes #7638

Proposed Changes

  • 🧹 Merge rekt e2e pairs that already share eventshub.WithTLS into single TLSAndOIDC tests with TLS / OIDC subtests
  • Keep OIDC-only audience/compliance tests (SupportsOIDC) separate, matching the issue hint
  • Resources covered in this PR: Parallel, PingSource, Sequence, ContainerSource, IntegrationSource (timer), JobSink

Why this shape

For these suites the TLS and OIDC event-send paths already use the same TLS-enabled eventshub environment; the OIDC path mainly adds an audience. Running them under one environment setup avoids redundant setup without changing feature coverage.

Left alone on purpose:

  • Test*SupportsOIDC (audience of input channel / compliance)
  • Broker/Channel TLS rotate + SupportsOIDC style suites where the overlap is not a clear shared event path (can be follow-ups)

Pre-review Checklist

  • At least 80% unit test coverage (n/a — rekt e2e organization only)
  • E2E tests reorganized; no new production behavior
  • Docs PR (n/a — no user-facing impact)
  • Spec PR (n/a)
  • Conformance test (n/a)

Release Note

NONE

Docs

n/a

Combine rekt tests that already share eventshub.WithTLS into single
TLSAndOIDC entry points with TLS/OIDC subtests. Leave SupportsOIDC
audience-compliance tests separate as they are OIDC-specific.

Fixes knative#7638

Signed-off-by: Vedant Madane <6527493+VedantMadane@users.noreply.github.com>
@knative-prow

knative-prow Bot commented Aug 9, 2026

Copy link
Copy Markdown

Welcome @VedantMadane! It looks like this is your first PR to knative/eventing 🎉

@knative-prow knative-prow Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 9, 2026
@knative-prow

knative-prow Bot commented Aug 9, 2026

Copy link
Copy Markdown

Hi @VedantMadane. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow

knative-prow Bot commented Aug 9, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: VedantMadane
Once this PR has been reviewed and has the lgtm label, please assign cardil for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot added the area/test-and-release Test infrastructure, tests or release label Aug 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/test-and-release Test infrastructure, tests or release needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Merge TLS and OIDC e2e tests

1 participant