test: merge overlapping TLS and OIDC rekt e2e suites - #9257
Conversation
Combine rekt tests that already share eventshub.WithTLS into single TLSAndOIDC entry points with TLS/OIDC subtests. Leave SupportsOIDC audience-compliance tests separate as they are OIDC-specific. Fixes knative#7638 Signed-off-by: Vedant Madane <6527493+VedantMadane@users.noreply.github.com>
|
Welcome @VedantMadane! It looks like this is your first PR to knative/eventing 🎉 |
|
Hi @VedantMadane. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: VedantMadane The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Fixes #7638
Proposed Changes
eventshub.WithTLSinto singleTLSAndOIDCtests withTLS/OIDCsubtestsSupportsOIDC) separate, matching the issue hintWhy this shape
For these suites the TLS and OIDC event-send paths already use the same TLS-enabled eventshub environment; the OIDC path mainly adds an audience. Running them under one environment setup avoids redundant setup without changing feature coverage.
Left alone on purpose:
Test*SupportsOIDC(audience of input channel / compliance)Pre-review Checklist
Release Note
Docs
n/a