feat(mcp): add 'invoke' tool and update documentation - #3986
Open
Ankitsinghsisodya wants to merge 4 commits into
Open
feat(mcp): add 'invoke' tool and update documentation#3986Ankitsinghsisodya wants to merge 4 commits into
Ankitsinghsisodya wants to merge 4 commits into
Conversation
- Introduced the 'invoke' tool to send test requests to running Function instances. - Updated instructions to include usage details for the 'invoke' tool, emphasizing the importance of absolute paths and providing guidance on parameters. - Added help resources for the 'invoke' command in the MCP server setup.
knative-prow
Bot
added
kind/enhancement
Contributor
Author
|
cc: @lkingland |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Ankitsinghsisodya The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an MCP invoke tool to the pkg/mcp server so agents can send test requests to a running Function (mirroring func invoke), plus a help resource and updated agent instructions to support a deploy-then-verify workflow.
Changes:
- Introduces
invokeas a new MCP tool backed byfunc invoke, with structured input/output and argument mapping. - Registers
invokein the MCP server and exposesfunc://help/invoke. - Updates MCP agent instructions to include
invokeguidance (notably post-deploy verification).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| pkg/mcp/tools_invoke.go | Implements the new invoke MCP tool and maps structured input to func invoke CLI flags. |
| pkg/mcp/tools_invoke_test.go | Adds unit tests validating argument passthrough, no-arg invocation behavior, and error surfacing. |
| pkg/mcp/mcp.go | Registers the invoke tool and adds the func://help/invoke resource. |
| pkg/mcp/instructions.md | Documents invoke usage and recommends deploy-then-invoke verification for agents. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…safety - Updated the documentation to clarify that the 'path' parameter is now required for the invoke tool, ensuring users specify the function directory. - Added cautionary notes regarding potential side effects when invoking functions, especially in remote scenarios. - Enhanced test coverage for the invoke tool, including checks for missing 'path' arguments and readonly mode restrictions.
- Clarified the 'target' parameter description in the InvokeInput struct to specify that it defaults to auto-discovery, preferring local when both local and remote instances are available. This enhances user understanding of the parameter's behavior.
- Updated the invoke tool to support CloudEvent extension attributes, allowing users to pass key-value pairs as repeated '--extension key=value' flags. - Modified the documentation to reflect that the MCP server's read-only mode now also disables the invoke operation, alongside deploy and delete. - Enhanced test coverage for the invoke tool, ensuring proper handling of extensions and readonly mode restrictions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
invokeMCP tool that lets agents send a test request to a local or remote running Function, mirroringfunc invoke(path, target, format, id, source, type, data, content-type, request-type, file, insecure, verbose)func://help/invokeMCP resource exposingfunc invoke --helpinvoketool in the MCP agent instructions, including the deploy-then-verify workflow (invoke a Function after deploying it to confirm it responds successfully before reporting success)/kind enhancement
Release Note
Docs