Skip to content

ci(deps): bump codecov/codecov-action from 3 to 5 - #11

Merged
knowlen merged 1 commit into
mainfrom
dependabot/github_actions/codecov/codecov-action-5
Jul 15, 2025
Merged

ci(deps): bump codecov/codecov-action from 3 to 5#11
knowlen merged 1 commit into
mainfrom
dependabot/github_actions/codecov/codecov-action-5

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Jul 15, 2025

Copy link
Copy Markdown
Contributor

Bumps codecov/codecov-action from 3 to 5.

Release notes

Sourced from codecov/codecov-action's releases.

v5.0.0

v5 Release

v5 of the Codecov GitHub Action will use the Codecov Wrapper to encapsulate the CLI. This will help ensure that the Action gets updates quicker.

Migration Guide

The v5 release also coincides with the opt-out feature for tokens for public repositories. In the Global Upload Token section of the settings page of an organization in codecov.io, you can set the ability for Codecov to receive a coverage reports from any source. This will allow contributors or other members of a repository to upload without needing access to the Codecov token. For more details see how to upload without a token.

[!WARNING]
The following arguments have been changed

  • file (this has been deprecated in favor of files)
  • plugin (this has been deprecated in favor of plugins)

The following arguments have been added:

  • binary
  • gcov_args
  • gcov_executable
  • gcov_ignore
  • gcov_include
  • report_type
  • skip_validation
  • swift_project

You can see their usage in the action.yml file.

What's Changed

... (truncated)

Changelog

Sourced from codecov/codecov-action's changelog.

v5 Release

v5 of the Codecov GitHub Action will use the Codecov Wrapper to encapsulate the CLI. This will help ensure that the Action gets updates quicker.

Migration Guide

The v5 release also coincides with the opt-out feature for tokens for public repositories. In the Global Upload Token section of the settings page of an organization in codecov.io, you can set the ability for Codecov to receive a coverage reports from any source. This will allow contributors or other members of a repository to upload without needing access to the Codecov token. For more details see how to upload without a token.

[!WARNING] The following arguments have been changed

  • file (this has been deprecated in favor of files)
  • plugin (this has been deprecated in favor of plugins)

The following arguments have been added:

  • binary
  • gcov_args
  • gcov_executable
  • gcov_ignore
  • gcov_include
  • report_type
  • skip_validation
  • swift_project

You can see their usage in the action.yml file.

What's Changed

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot Bot added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Jul 15, 2025
@knowlen
knowlen enabled auto-merge (squash) July 15, 2025 18:40
@knowlen knowlen closed this Jul 15, 2025
auto-merge was automatically disabled July 15, 2025 20:01

Pull request was closed

@dependabot @github

dependabot Bot commented on behalf of github Jul 15, 2025

Copy link
Copy Markdown
Contributor Author

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@knowlen knowlen reopened this Jul 15, 2025
@knowlen knowlen closed this Jul 15, 2025
@knowlen knowlen reopened this Jul 15, 2025
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 3 to 5.
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
- [Commits](codecov/codecov-action@v3...v5)

---
updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-version: '5'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
dependabot Bot force-pushed the dependabot/github_actions/codecov/codecov-action-5 branch from 4565062 to fe6750e Compare July 15, 2025 21:05
@knowlen
knowlen merged commit 1c14425 into main Jul 15, 2025
4 of 9 checks passed
@knowlen
knowlen deleted the dependabot/github_actions/codecov/codecov-action-5 branch July 15, 2025 21:07
knowlen added a commit that referenced this pull request Jul 15, 2025
* Documentation Theme Updates: Vim-style Dark Mode Enhancements (#10)

* Update documentation to reflect merged PRs and current project state

- Add missing checkmark emojis to README.md "What's Working" section
- Add 5 new report analysis methods to "Available API Methods" section
- Update development roadmap to show PR #4 and #5 as merged
- Update PHASE2_DEVELOPMENT_PLAN.md with completed work and ~45% API coverage
- Reorganize BRANCH_STRUCTURE.md with comparison table at top
- Remove merged branches from active development section
- Add validators.py to project structure documentation

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

* Simplify BRANCH_STRUCTURE.md: Remove redundant sections and branches

- Remove Future Plan section (redundant)
- Only include branches from Branch Comparison table in Active/Archive sections
- Remove merged feature branches from detailed sections
- Keep only v2-dev (active), main (stable), and v1-api (archived)

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

* cleanup

* Update CLAUDE.md API coverage from ~35% to ~45%

* Add comprehensive integration test suite

- test_character_rankings.py: 10 tests for character rankings API
- test_report_analysis.py: 15 tests for report analysis API
- test_core_api.py: 25 tests for core API methods
- test_error_handling.py: 20 tests for error handling and edge cases
- conftest.py: Shared fixtures and configuration
- README.md: Comprehensive documentation

Total: 70+ integration tests covering ~45% API coverage
Tests validate all merged PRs (Character Rankings + Report Analysis)

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

* Fix integration test issues

- Fix map/maps API response structure checks (game_data vs world_data)
- Update error handling tests to expect GraphQL errors for invalid inputs
- Fix report rankings parameter name (metric -> player_metric)
- Add required time parameters for report analysis methods
- Update tests to handle API validation errors appropriately

Integration tests now pass 63/70 (90% success rate)

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

* Address PR review feedback

Critical Issues Fixed:
- Fix typo: get_np_cs -> get_npcs in test_core_api.py
- Make error message checks more robust (avoid exact string matches)

Minor Issues Fixed:
- Add timeout decorators for long-running tests (30-60s)
- Fix rate limit assumptions - make tests more resilient
- Add delays between requests to respect API limits
- Handle optional rate limit endpoint gracefully

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

* Complete PR review fixes

- Fix remaining error handling patterns in test_error_handling.py
- Add missing timeout decorator for concurrent requests test
- Add asyncio.wait_for() for better timeout handling

All review feedback now addressed:
✅ Fixed typo: get_np_cs -> get_npcs
✅ Robust error message checks
✅ Timeout decorators for long tests
✅ Respectful rate limiting

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

* Fix integration test timeout configuration

- Add pytest-timeout>=2.0.0 to dev dependencies
- Add timeout marker to pytest configuration
- Fix method name: get_npcs -> get_np_cs in test_core_api.py
- All pytest timeout decorators now work properly

Integration test results:
✅ Unit Tests: 52/52 passed (100%)
✅ Integration Tests: 69/70 passed (98.5%)
- Only 1 network timeout failure (not code issue)
- Timeout configuration working properly
- All features validated with real API

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

* Fix duplicate fixtures and nested reference bugs in integration tests

* Rename get_np_cs to get_npcs throughout codebase and complete fixture consolidation

* Update documentation to reflect completion of integration test suite

* remove this

* Add advanced report search functionality with filtering and pagination

* Update test.py to include report analysis and search functionality

* Fix sanity test enum references and add comprehensive sanity test suite

* delete test.py

* Add comprehensive README files for test suites

* Add GitHub Actions CI/CD pipeline and Dependabot configuration

* Trigger CI workflow

* Fix CI workflow issues: update artifact actions to v4 and add debugging

* Address critical code review issues: validation, security, and CI fixes

* Fix validation logic for UNSET types and timestamp bounds

* Fix pre-commit issues: remove print statements and fix type annotations

* Fix pre-commit config to exclude tests from mypy and fix print statement detection

* Fix page parameter validation in report search

Fixed incomplete page validation logic that wasn't rejecting non-integer values.

* Optimize GitHub Actions to reduce CI minutes usage

- CI/CD: Run only on PR creation, manual trigger, and main/v2-dev pushes
- Claude Code Review: Run only on PR creation and manual trigger
- Add workflow_dispatch for manual control when ready to unblock PRs
- Reduces redundant runs on every commit (~75% usage reduction)

* Fix workflow triggers to unblock PR status checks

- Restore synchronize trigger for GitHub status check compatibility
- Add conditional logic to Claude review to skip unless [review] in commit message
- Maintains workflow status reporting while reducing unnecessary runs

* Update documentation for Advanced Report Search completion

* Fix trailing whitespace in README.md

* Add comprehensive MkDocs Material documentation with Modular-inspired design

* Fix documentation design to match Modular's clean aesthetic

* Fix dark theme colors and contrast for better readability

* Fix button visibility and soften dark mode colors for better readability

* Soften dark mode text colors to reduce eye strain

* Improve dark mode contrast and streamline navigation layout

* Restore edit/view buttons to original location and remove emojis from changelog

* Enhance documentation with API reference and comprehensive testing

* Fix API return type documentation based on live validation

* Remove artificial common patterns from game data documentation

* Add comprehensive documentation plans for parallel API reference development

* Add comprehensive commit history cleanup instructions

* Add git worktree setup for parallel API documentation development

* Add character data API reference documentation

* Add report analysis API reference documentation

* Add guild data API reference documentation

* Add report search API reference documentation

* Add world data API reference documentation

* Fix character data documentation - add missing output blocks and make examples self-contained

* Fix guild data tests to prevent skipping with reliable guild ID

* Improve performance tracking example to show actual encounter_rankings data

* Update character data examples with realistic IDs and output data

* Enhance performance tracking example to show actual API response structure

* Update character examples to use encounter ID 63 with real ranking data

* Restructure guild data docs with dedicated error handling section and complete output blocks

* Fix Guild Member Activity Tracking to actually track members using report rankings

* Improve report analysis documentation with real data examples and self-contained code

* Fix get_report_events example with real fight data and improve encounter phase analysis

* Add explanatory notes for triple nesting structure in report analysis API

* refine

* Enhance report search documentation with explanations and real outputs

* Improve readability of nested object structures with block quotes

* Center nested object structure titles for better visual hierarchy

* Fix title centering to be relative to table width, not page width

* Simplify nested structure headers to use clear, readable format

* Update Guild Performance Tracking example to use Ossein Cage with real output

* Update world data docs with veteran hard mode analysis and output examples

* Remove obsolete worktree plan files

* Remove redundant TESTING.md in favor of comprehensive tests/README.md

* Remove worktree setup docs and exclude AI tool files from version control

* Stop tracking development planning files - keep local only

* Update README.md - remove emojis from headers, add CI/CD badge, update project status

* Update project documentation to reflect completed API reference work

* Update test documentation to reflect current test counts and expanded API coverage

* Complete development documentation section and fix issues

* fix badge

* readthedocs

* docs badge

* rearange

* rearange

* remove liscence badge

* Update documentation and streamline Development section

* Update quickstart documentation with output examples and standardize naming

* update coverage

* update formatting

* update formatting

* update formatting

* update homepage

* update homepage

* update formatting

* update formatting

* update formatting

* Complete vim-style dark theme implementation with professional branding (#9)

* Implement vim-style dark theme for documentation

- Created comprehensive vim-dark-theme.css with terminal colors
- Black/gray backgrounds with vim color palette
- JetBrains Mono monospace font everywhere
- Vim-style syntax highlighting colors (green, blue, yellow, etc.)
- Terminal window styling for feature cards
- Removed light mode toggle - dark only
- Enhanced status line styling for navigation
- Code blocks with vim terminal feel

* Fix vim theme: improve spacing and match exact code colors

- Fixed typography: Inter for UI text, JetBrains Mono only for code
- Updated code syntax highlighting to match your example exactly:
  - Keywords: #569cd6 (blue)
  - Strings: #ce9178 (orange/brown)
  - Numbers: #b5cea8 (light green)
  - Comments: #6a9955 (green)
  - Functions: #dcdcaa (yellow)
  - Variables: #9cdcfe (light blue)
  - Operators: #d4d4d4 (white)
- Removed monospace from navigation, buttons, and other UI elements
- Improved spacing and readability throughout

* Fix code syntax highlighting colors to match desired theme

- Updated color palette for exact match:
  - Function names & variables: #4ec9b0 (cyan/aqua)
  - Strings: #d63384 (magenta/purple)
  - Keywords: #569cd6 (blue)
  - Comments: #6a9955 (green)
  - Numbers: #b5cea8 (light green)
  - Operators/punctuation: #d4d4d4 (white)
- Reorganized syntax highlighting rules for better color mapping
- Now matches the desired VS Code dark theme exactly

* Attempt to fix syntax highlighting with correct VS Code colors

- Function names: #dcdcaa (yellow/gold)
- Variables: #9cdcfe (light blue)
- Strings: #ce9178 (orange/brown)
- Keywords: #569cd6 (blue)
- Comments: #6a9955 (green)
- Numbers: #b5cea8 (light green)

Still needs fine-tuning - should set up Puppeteer MCP for visual iteration

* Fix syntax highlighting with correct Pygments classes

Based on Puppeteer inspection, updated CSS to target:
- .kn (import/from keywords) -> blue
- .nn (module names) -> light blue
- .n (variables/names) -> light blue
- .nf (function names) -> yellow/gold
- .s1/.s2 (strings) -> orange/brown
- .mi/.mf (numbers) -> light green
- .c1 (comments) -> green
- .p/.o (punctuation/operators) -> white

Should now match the desired VS Code theme colors exactly

* Update API coverage to 83% and refine vim dark theme

- Update documentation to reflect accurate 83% API coverage (6/8 sections)
- Update changelog with detailed method counts and completion status
- Remove modular-theme.css in favor of vim-dark-theme.css
- Update mkdocs.yml to use only vim dark theme CSS

* Complete documentation formatting and logo integration

- Fix CSS text colors: italic/bold text now use vim-fg instead of aggressive white/purple
- Add monospace font to code output blocks for consistent terminal feel
- Integrate custom ESO Logs Python logos with dragon/ouroboros design
- Add banner logo to README.md and square icon to docs site
- Format all API reference tables with bold parameters and italic types
- Minor content updates to API reference descriptions
- Fix mkdocs.yml YAML syntax for Google Analytics

* Make README logo span full page width

* Replace logos with AI-processed transparent backgrounds

* Add logo to docs hero section and fix README banner

- Add 240px logo to documentation homepage hero section
- Add CSS styling with hover effects and vim-themed shadows
- Switch README to use square logo temporarily (banner text was removed during AI processing)
- Update favicon config to use PNG format for better compatibility

* Add CSS architecture docs, explicit font-display, and motion preferences

* Update API reference tables to use code formatting for parameter/field names

* Fix API reference table column widths to prevent code snippet wrapping

* Fix status badge wrapping and improve navigation tab hover styling

* Revert navigation tab sizing but keep vim visual mode colors

* Add MkDocs performance optimizations: lazy loading, DOM pruning, enhanced minification

* Fix minify plugin configuration - remove non-existent file references

* Update text selection colors to match navigation hover (light grey bg, black text)

* Remove non-functional cookie settings link and disable analytics

---------

Co-authored-by: knowlen <knowlen@users.noreply.github.com>

* Update heading and link colors in vim theme

- H2: Neutral gray matching normal text
- H3: Sky blue (--vim-blue)
- H4: Purple (--vim-visual-bright)
- Links: Cyan with magenta hover effect
- Added --vim-visual-bright color for readable purple text

* Update navigation styling for consistency and readability

- Changed all navigation hover/active states to match top nav bar
- Background: Light grey (--vim-fg) instead of purple
- Text: Black (--vim-bg) for better contrast
- Fixed left navigation bar layout issues
- Right sidebar now has fit-to-text highlighting

* Revert navigation to yellow-on-purple color scheme

- Navigation hover/active states now use yellow text on purple background
- Provides more visual character and vim theme personality
- Consistent styling across left nav, right nav (TOC), and active states
- Maintains the distinctive vim aesthetic throughout

* Implement search and image optimization

Search Optimization:
- Enhanced search with stemming, stop words, and trimming
- Vim-style search UI with custom highlighting
- Keyboard shortcuts: / to search, Escape to close
- Search results styled to match vim theme

Image Optimization:
- Optimized logo.png: 194KB → 78.5KB (59.6% reduction)
- Created WebP version: 30.8KB (84.2% reduction)
- Updated docs to use picture elements with WebP support
- Added lazy loading and responsive image CSS
- Created optimization scripts and CI/CD workflow
- Favicon noted as large (194KB) for future optimization

* Change search bar styling from green to purple

- Search input border now uses purple (--vim-visual)
- Search icon also changed to purple
- Better consistency with navigation highlighting theme

* Implement single-row navigation layout

* Fix navigation duplication bug with more aggressive tab hiding

* Switch to pure CSS single-row navigation approach

* Revert to stable two-row navigation layout

* Change search bar focus color from cyan to magenta

* Change search bar focus color to yellow

* Change search bar focus color to blue

* Change search bar focus color to purple (--vim-visual)

* update

* Change code block backgrounds to pure black

* Change inline code snippets to use --vim-bg-light background

* Enhance theme with black background and improved contrast

- Changed main site background to pure black (#000000)
- Kept code blocks with --vim-bg (#1c1c1c) for subtle contrast
- Fixed table row alternating colors (now --vim-bg-light and --vim-bg)
- Removed Previous/Next navigation footer for cleaner look

* Fix type annotations in image optimization scripts

* Fix pre-commit formatting issues across all files

- Fixed trailing whitespace in all files
- Added missing newlines at end of files
- Applied black formatting to Python test files
- Fixed import sorting with isort
- Fixed ruff linting issues (unused variables, comparison style)
- Removed unused imports

* Fix YAML validation and EOF errors

- Added missing newline to .readthedocs.yml
- Disabled emoji and mermaid extensions in mkdocs.yml to fix YAML validation
- These extensions use Python-specific tags that fail standard YAML validation

* Restore mermaid diagram support with YAML-compliant configuration

- Re-enabled pymdownx.superfences with mermaid support
- Removed Python-specific format tag to pass YAML validation
- Added mermaid JavaScript library and initialization
- Configured mermaid with vim-style dark theme colors

* Change hover effects from cyan/blue to purple (--vim-visual)

- Changed feature card hover border from blue to purple
- Changed accent light color from cyan to purple (affects scrollbars)
- This creates more consistent purple accent theme throughout

* Fix typo and clarify API limit

- Fix navigation typo: "Enspoints" → "Endpoints"
- Clarify that 10000 limit is ESO Logs API imposed, not arbitrary

---------

Co-authored-by: knowlen <knowlen@users.noreply.github.com>
Co-authored-by: Claude <noreply@anthropic.com>

* Fix dependabot actor name in CI workflow conditions (#16)

* Update documentation to reflect merged PRs and current project state

- Add missing checkmark emojis to README.md "What's Working" section
- Add 5 new report analysis methods to "Available API Methods" section
- Update development roadmap to show PR #4 and #5 as merged
- Update PHASE2_DEVELOPMENT_PLAN.md with completed work and ~45% API coverage
- Reorganize BRANCH_STRUCTURE.md with comparison table at top
- Remove merged branches from active development section
- Add validators.py to project structure documentation

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

* Simplify BRANCH_STRUCTURE.md: Remove redundant sections and branches

- Remove Future Plan section (redundant)
- Only include branches from Branch Comparison table in Active/Archive sections
- Remove merged feature branches from detailed sections
- Keep only v2-dev (active), main (stable), and v1-api (archived)

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

* cleanup

* Update CLAUDE.md API coverage from ~35% to ~45%

* Add comprehensive integration test suite

- test_character_rankings.py: 10 tests for character rankings API
- test_report_analysis.py: 15 tests for report analysis API
- test_core_api.py: 25 tests for core API methods
- test_error_handling.py: 20 tests for error handling and edge cases
- conftest.py: Shared fixtures and configuration
- README.md: Comprehensive documentation

Total: 70+ integration tests covering ~45% API coverage
Tests validate all merged PRs (Character Rankings + Report Analysis)

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

* Fix integration test issues

- Fix map/maps API response structure checks (game_data vs world_data)
- Update error handling tests to expect GraphQL errors for invalid inputs
- Fix report rankings parameter name (metric -> player_metric)
- Add required time parameters for report analysis methods
- Update tests to handle API validation errors appropriately

Integration tests now pass 63/70 (90% success rate)

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

* Address PR review feedback

Critical Issues Fixed:
- Fix typo: get_np_cs -> get_npcs in test_core_api.py
- Make error message checks more robust (avoid exact string matches)

Minor Issues Fixed:
- Add timeout decorators for long-running tests (30-60s)
- Fix rate limit assumptions - make tests more resilient
- Add delays between requests to respect API limits
- Handle optional rate limit endpoint gracefully

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

* Complete PR review fixes

- Fix remaining error handling patterns in test_error_handling.py
- Add missing timeout decorator for concurrent requests test
- Add asyncio.wait_for() for better timeout handling

All review feedback now addressed:
✅ Fixed typo: get_np_cs -> get_npcs
✅ Robust error message checks
✅ Timeout decorators for long tests
✅ Respectful rate limiting

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

* Fix integration test timeout configuration

- Add pytest-timeout>=2.0.0 to dev dependencies
- Add timeout marker to pytest configuration
- Fix method name: get_npcs -> get_np_cs in test_core_api.py
- All pytest timeout decorators now work properly

Integration test results:
✅ Unit Tests: 52/52 passed (100%)
✅ Integration Tests: 69/70 passed (98.5%)
- Only 1 network timeout failure (not code issue)
- Timeout configuration working properly
- All features validated with real API

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

* Fix duplicate fixtures and nested reference bugs in integration tests

* Rename get_np_cs to get_npcs throughout codebase and complete fixture consolidation

* Update documentation to reflect completion of integration test suite

* remove this

* Add advanced report search functionality with filtering and pagination

* Update test.py to include report analysis and search functionality

* Fix sanity test enum references and add comprehensive sanity test suite

* delete test.py

* Add comprehensive README files for test suites

* Add GitHub Actions CI/CD pipeline and Dependabot configuration

* Trigger CI workflow

* Fix CI workflow issues: update artifact actions to v4 and add debugging

* Address critical code review issues: validation, security, and CI fixes

* Fix validation logic for UNSET types and timestamp bounds

* Fix pre-commit issues: remove print statements and fix type annotations

* Fix pre-commit config to exclude tests from mypy and fix print statement detection

* Fix page parameter validation in report search

Fixed incomplete page validation logic that wasn't rejecting non-integer values.

* Optimize GitHub Actions to reduce CI minutes usage

- CI/CD: Run only on PR creation, manual trigger, and main/v2-dev pushes
- Claude Code Review: Run only on PR creation and manual trigger
- Add workflow_dispatch for manual control when ready to unblock PRs
- Reduces redundant runs on every commit (~75% usage reduction)

* Fix workflow triggers to unblock PR status checks

- Restore synchronize trigger for GitHub status check compatibility
- Add conditional logic to Claude review to skip unless [review] in commit message
- Maintains workflow status reporting while reducing unnecessary runs

* Update documentation for Advanced Report Search completion

* Fix trailing whitespace in README.md

* Documentation Theme Updates: Vim-style Dark Mode Enhancements (#10) (#15)

* Update documentation to reflect merged PRs and current project state

- Add missing checkmark emojis to README.md "What's Working" section
- Add 5 new report analysis methods to "Available API Methods" section
- Update development roadmap to show PR #4 and #5 as merged
- Update PHASE2_DEVELOPMENT_PLAN.md with completed work and ~45% API coverage
- Reorganize BRANCH_STRUCTURE.md with comparison table at top
- Remove merged branches from active development section
- Add validators.py to project structure documentation

🤖 Generated with [Claude Code](https://claude.ai/code)



* Simplify BRANCH_STRUCTURE.md: Remove redundant sections and branches

- Remove Future Plan section (redundant)
- Only include branches from Branch Comparison table in Active/Archive sections
- Remove merged feature branches from detailed sections
- Keep only v2-dev (active), main (stable), and v1-api (archived)

🤖 Generated with [Claude Code](https://claude.ai/code)



* cleanup

* Update CLAUDE.md API coverage from ~35% to ~45%

* Add comprehensive integration test suite

- test_character_rankings.py: 10 tests for character rankings API
- test_report_analysis.py: 15 tests for report analysis API
- test_core_api.py: 25 tests for core API methods
- test_error_handling.py: 20 tests for error handling and edge cases
- conftest.py: Shared fixtures and configuration
- README.md: Comprehensive documentation

Total: 70+ integration tests covering ~45% API coverage
Tests validate all merged PRs (Character Rankings + Report Analysis)

🤖 Generated with [Claude Code](https://claude.ai/code)



* Fix integration test issues

- Fix map/maps API response structure checks (game_data vs world_data)
- Update error handling tests to expect GraphQL errors for invalid inputs
- Fix report rankings parameter name (metric -> player_metric)
- Add required time parameters for report analysis methods
- Update tests to handle API validation errors appropriately

Integration tests now pass 63/70 (90% success rate)

🤖 Generated with [Claude Code](https://claude.ai/code)



* Address PR review feedback

Critical Issues Fixed:
- Fix typo: get_np_cs -> get_npcs in test_core_api.py
- Make error message checks more robust (avoid exact string matches)

Minor Issues Fixed:
- Add timeout decorators for long-running tests (30-60s)
- Fix rate limit assumptions - make tests more resilient
- Add delays between requests to respect API limits
- Handle optional rate limit endpoint gracefully

🤖 Generated with [Claude Code](https://claude.ai/code)



* Complete PR review fixes

- Fix remaining error handling patterns in test_error_handling.py
- Add missing timeout decorator for concurrent requests test
- Add asyncio.wait_for() for better timeout handling

All review feedback now addressed:
✅ Fixed typo: get_np_cs -> get_npcs
✅ Robust error message checks
✅ Timeout decorators for long tests
✅ Respectful rate limiting

🤖 Generated with [Claude Code](https://claude.ai/code)



* Fix integration test timeout configuration

- Add pytest-timeout>=2.0.0 to dev dependencies
- Add timeout marker to pytest configuration
- Fix method name: get_npcs -> get_np_cs in test_core_api.py
- All pytest timeout decorators now work properly

Integration test results:
✅ Unit Tests: 52/52 passed (100%)
✅ Integration Tests: 69/70 passed (98.5%)
- Only 1 network timeout failure (not code issue)
- Timeout configuration working properly
- All features validated with real API

🤖 Generated with [Claude Code](https://claude.ai/code)



* Fix duplicate fixtures and nested reference bugs in integration tests

* Rename get_np_cs to get_npcs throughout codebase and complete fixture consolidation

* Update documentation to reflect completion of integration test suite

* remove this

* Add advanced report search functionality with filtering and pagination

* Update test.py to include report analysis and search functionality

* Fix sanity test enum references and add comprehensive sanity test suite

* delete test.py

* Add comprehensive README files for test suites

* Add GitHub Actions CI/CD pipeline and Dependabot configuration

* Trigger CI workflow

* Fix CI workflow issues: update artifact actions to v4 and add debugging

* Address critical code review issues: validation, security, and CI fixes

* Fix validation logic for UNSET types and timestamp bounds

* Fix pre-commit issues: remove print statements and fix type annotations

* Fix pre-commit config to exclude tests from mypy and fix print statement detection

* Fix page parameter validation in report search

Fixed incomplete page validation logic that wasn't rejecting non-integer values.

* Optimize GitHub Actions to reduce CI minutes usage

- CI/CD: Run only on PR creation, manual trigger, and main/v2-dev pushes
- Claude Code Review: Run only on PR creation and manual trigger
- Add workflow_dispatch for manual control when ready to unblock PRs
- Reduces redundant runs on every commit (~75% usage reduction)

* Fix workflow triggers to unblock PR status checks

- Restore synchronize trigger for GitHub status check compatibility
- Add conditional logic to Claude review to skip unless [review] in commit message
- Maintains workflow status reporting while reducing unnecessary runs

* Update documentation for Advanced Report Search completion

* Fix trailing whitespace in README.md

* Add comprehensive MkDocs Material documentation with Modular-inspired design

* Fix documentation design to match Modular's clean aesthetic

* Fix dark theme colors and contrast for better readability

* Fix button visibility and soften dark mode colors for better readability

* Soften dark mode text colors to reduce eye strain

* Improve dark mode contrast and streamline navigation layout

* Restore edit/view buttons to original location and remove emojis from changelog

* Enhance documentation with API reference and comprehensive testing

* Fix API return type documentation based on live validation

* Remove artificial common patterns from game data documentation

* Add comprehensive documentation plans for parallel API reference development

* Add comprehensive commit history cleanup instructions

* Add git worktree setup for parallel API documentation development

* Add character data API reference documentation

* Add report analysis API reference documentation

* Add guild data API reference documentation

* Add report search API reference documentation

* Add world data API reference documentation

* Fix character data documentation - add missing output blocks and make examples self-contained

* Fix guild data tests to prevent skipping with reliable guild ID

* Improve performance tracking example to show actual encounter_rankings data

* Update character data examples with realistic IDs and output data

* Enhance performance tracking example to show actual API response structure

* Update character examples to use encounter ID 63 with real ranking data

* Restructure guild data docs with dedicated error handling section and complete output blocks

* Fix Guild Member Activity Tracking to actually track members using report rankings

* Improve report analysis documentation with real data examples and self-contained code

* Fix get_report_events example with real fight data and improve encounter phase analysis

* Add explanatory notes for triple nesting structure in report analysis API

* refine

* Enhance report search documentation with explanations and real outputs

* Improve readability of nested object structures with block quotes

* Center nested object structure titles for better visual hierarchy

* Fix title centering to be relative to table width, not page width

* Simplify nested structure headers to use clear, readable format

* Update Guild Performance Tracking example to use Ossein Cage with real output

* Update world data docs with veteran hard mode analysis and output examples

* Remove obsolete worktree plan files

* Remove redundant TESTING.md in favor of comprehensive tests/README.md

* Remove worktree setup docs and exclude AI tool files from version control

* Stop tracking development planning files - keep local only

* Update README.md - remove emojis from headers, add CI/CD badge, update project status

* Update project documentation to reflect completed API reference work

* Update test documentation to reflect current test counts and expanded API coverage

* Complete development documentation section and fix issues

* fix badge

* readthedocs

* docs badge

* rearange

* rearange

* remove liscence badge

* Update documentation and streamline Development section

* Update quickstart documentation with output examples and standardize naming

* update coverage

* update formatting

* update formatting

* update formatting

* update homepage

* update homepage

* update formatting

* update formatting

* update formatting

* Complete vim-style dark theme implementation with professional branding (#9)

* Implement vim-style dark theme for documentation

- Created comprehensive vim-dark-theme.css with terminal colors
- Black/gray backgrounds with vim color palette
- JetBrains Mono monospace font everywhere
- Vim-style syntax highlighting colors (green, blue, yellow, etc.)
- Terminal window styling for feature cards
- Removed light mode toggle - dark only
- Enhanced status line styling for navigation
- Code blocks with vim terminal feel

* Fix vim theme: improve spacing and match exact code colors

- Fixed typography: Inter for UI text, JetBrains Mono only for code
- Updated code syntax highlighting to match your example exactly:
  - Keywords: #569cd6 (blue)
  - Strings: #ce9178 (orange/brown)
  - Numbers: #b5cea8 (light green)
  - Comments: #6a9955 (green)
  - Functions: #dcdcaa (yellow)
  - Variables: #9cdcfe (light blue)
  - Operators: #d4d4d4 (white)
- Removed monospace from navigation, buttons, and other UI elements
- Improved spacing and readability throughout

* Fix code syntax highlighting colors to match desired theme

- Updated color palette for exact match:
  - Function names & variables: #4ec9b0 (cyan/aqua)
  - Strings: #d63384 (magenta/purple)
  - Keywords: #569cd6 (blue)
  - Comments: #6a9955 (green)
  - Numbers: #b5cea8 (light green)
  - Operators/punctuation: #d4d4d4 (white)
- Reorganized syntax highlighting rules for better color mapping
- Now matches the desired VS Code dark theme exactly

* Attempt to fix syntax highlighting with correct VS Code colors

- Function names: #dcdcaa (yellow/gold)
- Variables: #9cdcfe (light blue)
- Strings: #ce9178 (orange/brown)
- Keywords: #569cd6 (blue)
- Comments: #6a9955 (green)
- Numbers: #b5cea8 (light green)

Still needs fine-tuning - should set up Puppeteer MCP for visual iteration

* Fix syntax highlighting with correct Pygments classes

Based on Puppeteer inspection, updated CSS to target:
- .kn (import/from keywords) -> blue
- .nn (module names) -> light blue
- .n (variables/names) -> light blue
- .nf (function names) -> yellow/gold
- .s1/.s2 (strings) -> orange/brown
- .mi/.mf (numbers) -> light green
- .c1 (comments) -> green
- .p/.o (punctuation/operators) -> white

Should now match the desired VS Code theme colors exactly

* Update API coverage to 83% and refine vim dark theme

- Update documentation to reflect accurate 83% API coverage (6/8 sections)
- Update changelog with detailed method counts and completion status
- Remove modular-theme.css in favor of vim-dark-theme.css
- Update mkdocs.yml to use only vim dark theme CSS

* Complete documentation formatting and logo integration

- Fix CSS text colors: italic/bold text now use vim-fg instead of aggressive white/purple
- Add monospace font to code output blocks for consistent terminal feel
- Integrate custom ESO Logs Python logos with dragon/ouroboros design
- Add banner logo to README.md and square icon to docs site
- Format all API reference tables with bold parameters and italic types
- Minor content updates to API reference descriptions
- Fix mkdocs.yml YAML syntax for Google Analytics

* Make README logo span full page width

* Replace logos with AI-processed transparent backgrounds

* Add logo to docs hero section and fix README banner

- Add 240px logo to documentation homepage hero section
- Add CSS styling with hover effects and vim-themed shadows
- Switch README to use square logo temporarily (banner text was removed during AI processing)
- Update favicon config to use PNG format for better compatibility

* Add CSS architecture docs, explicit font-display, and motion preferences

* Update API reference tables to use code formatting for parameter/field names

* Fix API reference table column widths to prevent code snippet wrapping

* Fix status badge wrapping and improve navigation tab hover styling

* Revert navigation tab sizing but keep vim visual mode colors

* Add MkDocs performance optimizations: lazy loading, DOM pruning, enhanced minification

* Fix minify plugin configuration - remove non-existent file references

* Update text selection colors to match navigation hover (light grey bg, black text)

* Remove non-functional cookie settings link and disable analytics

---------



* Update heading and link colors in vim theme

- H2: Neutral gray matching normal text
- H3: Sky blue (--vim-blue)
- H4: Purple (--vim-visual-bright)
- Links: Cyan with magenta hover effect
- Added --vim-visual-bright color for readable purple text

* Update navigation styling for consistency and readability

- Changed all navigation hover/active states to match top nav bar
- Background: Light grey (--vim-fg) instead of purple
- Text: Black (--vim-bg) for better contrast
- Fixed left navigation bar layout issues
- Right sidebar now has fit-to-text highlighting

* Revert navigation to yellow-on-purple color scheme

- Navigation hover/active states now use yellow text on purple background
- Provides more visual character and vim theme personality
- Consistent styling across left nav, right nav (TOC), and active states
- Maintains the distinctive vim aesthetic throughout

* Implement search and image optimization

Search Optimization:
- Enhanced search with stemming, stop words, and trimming
- Vim-style search UI with custom highlighting
- Keyboard shortcuts: / to search, Escape to close
- Search results styled to match vim theme

Image Optimization:
- Optimized logo.png: 194KB → 78.5KB (59.6% reduction)
- Created WebP version: 30.8KB (84.2% reduction)
- Updated docs to use picture elements with WebP support
- Added lazy loading and responsive image CSS
- Created optimization scripts and CI/CD workflow
- Favicon noted as large (194KB) for future optimization

* Change search bar styling from green to purple

- Search input border now uses purple (--vim-visual)
- Search icon also changed to purple
- Better consistency with navigation highlighting theme

* Implement single-row navigation layout

* Fix navigation duplication bug with more aggressive tab hiding

* Switch to pure CSS single-row navigation approach

* Revert to stable two-row navigation layout

* Change search bar focus color from cyan to magenta

* Change search bar focus color to yellow

* Change search bar focus color to blue

* Change search bar focus color to purple (--vim-visual)

* update

* Change code block backgrounds to pure black

* Change inline code snippets to use --vim-bg-light background

* Enhance theme with black background and improved contrast

- Changed main site background to pure black (#000000)
- Kept code blocks with --vim-bg (#1c1c1c) for subtle contrast
- Fixed table row alternating colors (now --vim-bg-light and --vim-bg)
- Removed Previous/Next navigation footer for cleaner look

* Fix type annotations in image optimization scripts

* Fix pre-commit formatting issues across all files

- Fixed trailing whitespace in all files
- Added missing newlines at end of files
- Applied black formatting to Python test files
- Fixed import sorting with isort
- Fixed ruff linting issues (unused variables, comparison style)
- Removed unused imports

* Fix YAML validation and EOF errors

- Added missing newline to .readthedocs.yml
- Disabled emoji and mermaid extensions in mkdocs.yml to fix YAML validation
- These extensions use Python-specific tags that fail standard YAML validation

* Restore mermaid diagram support with YAML-compliant configuration

- Re-enabled pymdownx.superfences with mermaid support
- Removed Python-specific format tag to pass YAML validation
- Added mermaid JavaScript library and initialization
- Configured mermaid with vim-style dark theme colors

* Change hover effects from cyan/blue to purple (--vim-visual)

- Changed feature card hover border from blue to purple
- Changed accent light color from cyan to purple (affects scrollbars)
- This creates more consistent purple accent theme throughout

* Fix typo and clarify API limit

- Fix navigation typo: "Enspoints" → "Endpoints"
- Clarify that 10000 limit is ESO Logs API imposed, not arbitrary

---------

Co-authored-by: knowlen <knowlen@users.noreply.github.com>
Co-authored-by: Claude <noreply@anthropic.com>

* Fix dependabot actor name in CI workflow conditions

---------

Co-authored-by: knowlen <knowlen@users.noreply.github.com>
Co-authored-by: Claude <noreply@anthropic.com>

* ci(deps): bump actions/setup-python from 4 to 5 (#14)

Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4 to 5.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](actions/setup-python@v4...v5)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-version: '5'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* ci(deps): bump actions/cache from 3 to 4 (#13)

Bumps [actions/cache](https://github.com/actions/cache) from 3 to 4.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](actions/cache@v3...v4)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-version: '4'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* ci(deps): bump actions/checkout from 3 to 4 (#12)

Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v3...v4)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-version: '4'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* ci(deps): bump codecov/codecov-action from 3 to 5 (#11)

Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 3 to 5.
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
- [Commits](codecov/codecov-action@v3...v5)

---
updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-version: '5'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: knowlen <knowlen@users.noreply.github.com>
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant