Skip to content

Fix pending SSL data handling in stream client#2646

Open
mihirduvedi wants to merge 1 commit into
kubernetes-client:masterfrom
mihirduvedi:fix-2414-ssl-pending
Open

Fix pending SSL data handling in stream client#2646
mihirduvedi wants to merge 1 commit into
kubernetes-client:masterfrom
mihirduvedi:fix-2414-ssl-pending

Conversation

@mihirduvedi

Copy link
Copy Markdown

What type of PR is this?

/kind bug

What this PR does / why we need it:

WSClient.update() can wait on poll() or select() even when an SSL socket already has decrypted data buffered internally. This can delay stream output indefinitely when no additional network event arrives.

This change checks SSLSocket.pending() before polling and immediately processes a WebSocket frame when buffered SSL data is available. It also adds a deterministic regression test using timeout=None that verifies neither polling path is entered.

Which issue(s) this PR fixes:

Fixes #2414

Special notes for your reviewer:

This addresses the unit-test request from #2422 and the review feedback to avoid calling poll() or select() when SSL data is already pending.

Tests:

  • python -m pytest -q kubernetes/base/stream/ws_client_test.py — 17 passed
  • python -m pytest -q kubernetes/base --ignore=kubernetes/base/dynamic/test_client.py --ignore=kubernetes/base/dynamic/test_discovery.py — 143 passed

The two excluded dynamic-client modules require a live Kubernetes cluster.

Does this PR introduce a user-facing change?

Fixed stream operations over SSL to process buffered WebSocket data without waiting for another socket event.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@kubernetes-prow kubernetes-prow Bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Jul 22, 2026
@linux-foundation-easycla

linux-foundation-easycla Bot commented Jul 22, 2026

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: mihirduvedi / name: mihirduvedi (730aa78)

@kubernetes-prow kubernetes-prow Bot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jul 22, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

Welcome @mihirduvedi!

It looks like this is your first PR to kubernetes-client/python 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/python has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@kubernetes-prow kubernetes-prow Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 22, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mihirduvedi
Once this PR has been reviewed and has the lgtm label, please assign roycaihw for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow
kubernetes-prow Bot requested review from fabianvf and roycaihw July 22, 2026 23:17
@kubernetes-prow kubernetes-prow Bot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

stream api will lose data when use sslsocket

1 participant