KEP-1948: Adding KEP for allowing deallocate in device plugin API call #1949

mewais · 2020-08-18T23:11:24Z

#1948

k8s-ci-robot · 2020-08-18T23:11:33Z

Welcome @mewais!

It looks like this is your first PR to kubernetes/enhancements 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/enhancements has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2020-08-18T23:11:33Z

Hi @mewais. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

RenaudWasTaken · 2020-08-19T02:04:41Z

I'm surprised they didn't move the original design doc here!

Maybe instead of having a Kep for this specific feature, convert the design doc to a kep in the first commit (or a separate PR) and add a section with your feature in the second commit.

I think it makes more sense this way since we aren't versioning individual function calls but the whole API. What do you think?

mewais · 2020-08-19T03:08:11Z

I have a paper deadline approaching so I will have to apologize as it looks like a bit of work that I may not have time for. That design document is quite old, there are things already implemented in the device plugin API but never described in that document, and things described in the document that are no longer in the implementation. Plus the images are outdated (at least the second) and will need some changes.

If/When it is done, I'm happy to rebase this on top of it. On the other hand, if it is going to take time, is it fine if we just proceed with this and merge/rebase later?!

kikisdeliveryservice · 2020-08-29T01:20:49Z

keps/sig-node/1948-add-dellocate-to-device-plugin-api/kep.yaml

+  - "@mewais"
+owning-sig: sig-node
+participating-sigs: []
+status: implemented


This should be provisional or implementable - implemented is for KEPs that have been approved and whose work is completed.

mewais · 2020-08-29T04:59:27Z

@kikisdeliveryservice Fixed, thanks for the elaboration.

mewais · 2020-08-29T19:22:33Z

/assign @dchen1107

mewais · 2020-09-12T07:12:54Z

@dchen1107 @derekwaynecarr @kikisdeliveryservice Any updates about this?!

kikisdeliveryservice · 2020-09-13T23:09:27Z

@dchen1107 @derekwaynecarr @kikisdeliveryservice Any updates about this?!

Hi @mewais

Enhancements Lead here. I'd recommend bringing your KEP directly to sig-node and asking for feedback. Please see: https://github.com/kubernetes/community/tree/master/sig-node for meeting times and slack channels that might help.

Best,
Kirsten

mewais · 2020-09-13T23:45:08Z

@dchen1107 @derekwaynecarr @kikisdeliveryservice Any updates about this?!

Hi @mewais

Enhancements Lead here. I'd recommend bringing your KEP directly to sig-node and asking for feedback. Please see: https://github.com/kubernetes/community/tree/master/sig-node for meeting times and slack channels that might help.

Best,
Kirsten

Hi @kikisdeliveryservice

I have actually started a discussion about this on sig-node's slack channel, the discussion ended by suggesting that I create this KEP.
Anyway, I will bring up the KEP on the channel again and see where we go from there.

kikisdeliveryservice

This KEP is missing many sections from the template such as PRR, Design Details, graduation criteria & test criteria: https://github.com/kubernetes/enhancements/tree/master/keps/NNNN-kep-template

Please review the template and update accordingly.

mewais · 2020-11-11T21:42:07Z

Hi @kikisdeliveryservice

The KEP has been updated. I'll try to join some of the upcoming sig-node meetings to discuss.

ehashman · 2021-01-13T18:51:47Z

/ok-to-test

fujitatomoya

found a few typo

fujitatomoya · 2021-11-18T00:23:49Z

keps/sig-node/1948-add-deallocate-to-device-plugin-api/README.md

+
+This KEP proposes adding two extra API calls:
+- `Deallocate`: (Optional). Which is the opposite of allocate, and is needed to inform device plugins that some devices are no longer being used.
+- `PostStopContainer`: (Optional). Which allow the device plugins to do device cleanup, driver unloading, and any other actions that may be needed.


nit

Suggested change

- `PostStopContainer`: (Optional). Which allow the device plugins to do device cleanup, driver unloading, and any other actions that may be needed.

- `PostStopContainer`: (Optional). Which allows the device plugins to do device cleanup, driver unloading, and any other actions that may be needed.

fujitatomoya · 2021-11-18T00:28:22Z

keps/sig-node/1948-add-deallocate-to-device-plugin-api/README.md

+
+The device plugin API includes API calls for:
+- `Allocate`: Which is used to instruct device plugins to allocate device(s) to requesting containers.
+- `PreStartContainer`: (Optional). Which allow the device plugins to do device initialization, loading drivers, and any other initialization actions that may be needed.


Suggested change

- `PreStartContainer`: (Optional). Which allow the device plugins to do device initialization, loading drivers, and any other initialization actions that may be needed.

- `PreStartContainer`: (Optional). Which allows the device plugins to do device initialization, loading drivers, and any other initialization actions that may be needed.

fujitatomoya · 2021-11-18T00:28:38Z

keps/sig-node/1948-add-deallocate-to-device-plugin-api/README.md

+
+This KEP proposes adding two extra API calls, maintaining the same logical reasoning of the previous two. Those are:
+- `Deallocate`: (Optional). Which is the opposite of allocate, and is needed to inform device plugins that some devices are no longer being used (this used to happen silently before)
+- `PostStopContainer`: (Optional). Which allow the device plugins to do device cleanup, driver unloading, and any other cleanup actions that may be needed.


Suggested change

- `PostStopContainer`: (Optional). Which allow the device plugins to do device cleanup, driver unloading, and any other cleanup actions that may be needed.

- `PostStopContainer`: (Optional). Which allows the device plugins to do device cleanup, driver unloading, and any other cleanup actions that may be needed.

zvonkok · 2021-12-03T08:01:01Z

/cc @zvonkok

k8s-ci-robot · 2021-12-03T08:01:02Z

@zvonkok: GitHub didn't allow me to request PR reviews from the following users: zvonkok.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @zvonkok

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

zvonkok · 2021-12-03T10:48:42Z

As discussed on sig-node Nov. 30th, see notes, I am taking ownership of this KEP/PR. FYI @Windrow14 regarding #3074

TE-7000026184 · 2021-12-06T01:42:47Z

As discussed on sig-node Nov. 30th, see notes, I am taking ownership of this KEP/PR. FYI @Windrow14 regarding #3074

Got it, I closed that one.

fujitatomoya · 2021-12-06T16:35:13Z

@zvonkok thanks for taking responsibility. if there anything we can do escalate the process, just let us know? we can share our use cases in SIG, if needed. thanks!

bart0sh · 2021-12-07T09:17:13Z

@zvonkok Can you point us to the place(PR, issue, etc) where you're going to continue this work, please?

zvonkok · 2021-12-07T11:02:38Z

@fujitatomoya @bart0sh FYI #3080

bart0sh · 2022-02-01T11:15:22Z

@kubernetes/sig-node-pr-reviews please close this as this work has been moved to #3080

k8s-triage-robot · 2022-05-02T11:59:12Z

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot · 2022-06-01T12:29:00Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

zvonkok · 2022-06-01T13:57:39Z

/remove-lifecycle rotten

k8s-triage-robot · 2022-08-30T14:41:53Z

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

fujitatomoya · 2022-08-30T16:22:21Z

@kikisdeliveryservice @klueska probably we should close this? in favor of #3080 ?

k8s-triage-robot · 2022-10-16T03:12:34Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot · 2022-11-15T03:27:44Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen
Mark this PR as fresh with /remove-lifecycle rotten
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot · 2022-11-15T03:27:51Z

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied

After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied

After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen

Mark this PR as fresh with /remove-lifecycle rotten

Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

fujitatomoya · 2022-11-15T17:05:32Z

I think this can be closed in favor of #3080

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 18, 2020

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory labels Aug 18, 2020

k8s-ci-robot requested review from dchen1107 and derekwaynecarr August 18, 2020 23:11

k8s-ci-robot added sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Aug 18, 2020

This was referenced Aug 18, 2020

Device Plugin API feature: Add Deallocate and PostStopContainer to device plugin API #1948

Closed

Add Deallocate and PostStopContainer to device plugin API kubernetes/kubernetes#91190

Closed

kikisdeliveryservice reviewed Aug 29, 2020

View reviewed changes

k8s-ci-robot assigned dchen1107 Aug 29, 2020

mewais requested a review from kikisdeliveryservice September 8, 2020 03:13

kikisdeliveryservice reviewed Sep 27, 2020

View reviewed changes

mewais force-pushed the master branch 4 times, most recently from 2997506 to 039176b Compare November 11, 2020 21:41

k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jan 13, 2021

fujitatomoya reviewed Nov 18, 2021

View reviewed changes

TE-7000026184 mentioned this pull request Dec 3, 2021

KEP-1948: Device Plugin API feature: Adding KEP for allowing deallocate in device plugin API call (take over) #3074

Closed

zvonkok mentioned this pull request Dec 7, 2021

KEP-3162: Add Deallocate and PostStopContainer to Device Manager API #3080

Closed

klueska mentioned this pull request Feb 1, 2022

KEP-3063: dynamic resource allocation #3064

Merged

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 2, 2022

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 1, 2022

k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jun 1, 2022

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 30, 2022

kikisdeliveryservice changed the title ~~Adding KEP for allowing deallocate in device plugin API call~~ KEP-1948: Adding KEP for allowing deallocate in device plugin API call Sep 16, 2022

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 16, 2022

k8s-ci-robot closed this Nov 15, 2022

	- `PostStopContainer`: (Optional). Which allow the device plugins to do device cleanup, driver unloading, and any other actions that may be needed.
	- `PostStopContainer`: (Optional). Which allows the device plugins to do device cleanup, driver unloading, and any other actions that may be needed.

	- `PreStartContainer`: (Optional). Which allow the device plugins to do device initialization, loading drivers, and any other initialization actions that may be needed.
	- `PreStartContainer`: (Optional). Which allows the device plugins to do device initialization, loading drivers, and any other initialization actions that may be needed.

KEP-1948: Adding KEP for allowing deallocate in device plugin API call #1949

KEP-1948: Adding KEP for allowing deallocate in device plugin API call #1949

Uh oh!

Conversation

mewais commented Aug 18, 2020

Uh oh!

k8s-ci-robot commented Aug 18, 2020

Uh oh!

k8s-ci-robot commented Aug 18, 2020

Uh oh!

RenaudWasTaken commented Aug 19, 2020

Uh oh!

mewais commented Aug 19, 2020

Uh oh!

kikisdeliveryservice Aug 29, 2020

Choose a reason for hiding this comment

Uh oh!

mewais commented Aug 29, 2020

Uh oh!

mewais commented Aug 29, 2020

Uh oh!

mewais commented Sep 12, 2020

Uh oh!

kikisdeliveryservice commented Sep 13, 2020

Uh oh!

mewais commented Sep 13, 2020

Uh oh!

kikisdeliveryservice left a comment

Choose a reason for hiding this comment

Uh oh!

mewais commented Nov 11, 2020

Uh oh!

ehashman commented Jan 13, 2021

Uh oh!

fujitatomoya left a comment

Choose a reason for hiding this comment

Uh oh!

fujitatomoya Nov 18, 2021

Choose a reason for hiding this comment

Uh oh!

fujitatomoya Nov 18, 2021

Choose a reason for hiding this comment

Uh oh!

fujitatomoya Nov 18, 2021

Choose a reason for hiding this comment

Uh oh!

zvonkok commented Dec 3, 2021

Uh oh!

k8s-ci-robot commented Dec 3, 2021

Uh oh!

zvonkok commented Dec 3, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TE-7000026184 commented Dec 6, 2021

Uh oh!

fujitatomoya commented Dec 6, 2021

Uh oh!

bart0sh commented Dec 7, 2021

Uh oh!

zvonkok commented Dec 7, 2021

Uh oh!

bart0sh commented Feb 1, 2022

Uh oh!

k8s-triage-robot commented May 2, 2022

Uh oh!

k8s-triage-robot commented Jun 1, 2022

Uh oh!

zvonkok commented Jun 1, 2022

Uh oh!

k8s-triage-robot commented Aug 30, 2022

Uh oh!

fujitatomoya commented Aug 30, 2022

Uh oh!

k8s-triage-robot commented Oct 16, 2022

Uh oh!

k8s-triage-robot commented Nov 15, 2022

Uh oh!

k8s-ci-robot commented Nov 15, 2022

Uh oh!

fujitatomoya commented Nov 15, 2022

zvonkok commented Dec 3, 2021 •

edited

Loading