-
Notifications
You must be signed in to change notification settings - Fork 1.6k
KEP-1847: promote autoremove-statefulset-pvcs to GA #4197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
carlory
commented
Sep 8, 2023
- One-line PR description: promote autoremove-statefulset-pvcs to GA
- Issue link: Auto remove PVCs created by StatefulSet #1847
- Other comments:
|
/cc @mattcary |
|
/cc @msau42 Thanks, we're discussing the feature readiness. |
@mattcary any results from the discussions? |
|
Sorry for the delay in reply. We don't have any data on usage -- we had thought we could look at kube state metrics, but it turns out they're filtered in GKE and we don't have usage stats for this feature. So we can go off of issues surrounding the feature, which don't seem to be many. I'm not sure of the bar we have for GA. |
If that's the case, I'd rather not rush this, but let it soak for a bit more. |
|
Ok, thanks, I agree. I should have some time to figure out how to get fleet level statistics for usage, that will make me feel much more confident about it. |
|
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
|
FYI, we are going to soak the changes in kubernetes/kubernetes#122499 for a release and then go GA if all is good (I guess that's 1.31). |
|
/hold |
Great news! |
|
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
|
/remove-lifecycle stale |
|
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
|
@k8s-triage-robot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/reopen |
|
@carlory: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: carlory The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
|
@k8s-triage-robot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |