Node controller deletePod return true if there are pods pending deletion #30624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-github-robot
added
size/XS
derekwaynecarr
added
release-note-none
Contributor
|
LGTM |
gmarek
added
the
lgtm
k8s-github-robot
added
the
needs-rebase
Contributor
|
Error looks related - you uncovered a possibly blocking case |
derekwaynecarr
force-pushed
the
node-controller-fix
branch
from
8d0ea87 to
14a2b26
Compare
derekwaynecarr
removed
the
needs-rebase
k8s-github-robot
removed
the
lgtm
Member
Author
|
re-adding lgtm after rebase. |
derekwaynecarr
added
the
lgtm
|
GCE e2e build/test passed for commit 14a2b26. |
Contributor
|
Shouldn't there be a test coming along with bug fixes like this? |
|
Automatic merge from submit-queue |
jwhonce
pushed a commit
to jwhonce/kubernetes
that referenced
this pull request
Aug 19, 2016
…er-fix Automatic merge from submit-queue Node controller deletePod return true if there are pods pending deletion Fixes kubernetes#30536 If a node had a single pod in terminating state, and that node no longer reported healthy, the pod was never deleted by the node controller because it believed there were no pods remaining. @smarterclayton @ncdc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30536
If a node had a single pod in terminating state, and that node no longer reported healthy, the pod was never deleted by the node controller because it believed there were no pods remaining.
@smarterclayton @ncdc
This change is