Skip to content

schedule-builder: don't skip adding to EOL if next release is not set#4462

Open
azlkiniue wants to merge 1 commit into
kubernetes:masterfrom
azlkiniue:fix/schedule-builder
Open

schedule-builder: don't skip adding to EOL if next release is not set#4462
azlkiniue wants to merge 1 commit into
kubernetes:masterfrom
azlkiniue:fix/schedule-builder

Conversation

@azlkiniue

Copy link
Copy Markdown

What type of PR is this?

/kind bug

What this PR does / why we need it:

If the next release is not available, look for the latest previous patch available. Only skip if both are not available. The previous skip that was added to prevent a panic when the next release is not set still occurs after the EOL check. Also change EOL date value to use EndOfLifeDate instead of TargetDate.

Which issue(s) this PR fixes:

Fixes #4450

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

Fixed `schedule-builder` skipping the addition of releases to `eol.yaml` when the `next` field is not set in `schedule.yaml`.

If the next release is not available, look for the latest previous
patch available. Only skip if both are not available. The previous
skip that was added to prevent a panic when the next release is not
set still occurs after the EOL check. Also change EOL date value to
use EndOfLifeDate instead of TargetDate.

Signed-off-by: Ahmada Yusril <ahmadayusril@gmail.com>
@kubernetes-prow kubernetes-prow Bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Jul 10, 2026
@kubernetes-prow kubernetes-prow Bot requested a review from jimangel July 10, 2026 05:13
@kubernetes-prow kubernetes-prow Bot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 10, 2026
@kubernetes-prow kubernetes-prow Bot requested a review from salaxander July 10, 2026 05:13
@kubernetes-prow kubernetes-prow Bot added area/release-eng Issues or PRs related to the Release Engineering subproject needs-priority labels Jul 10, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: azlkiniue
Once this PR has been reviewed and has the lgtm label, please assign xmudrii for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added the sig/release Categorizes an issue or PR as relevant to SIG Release. label Jul 10, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

Welcome @azlkiniue!

It looks like this is your first PR to kubernetes/release 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/release has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@kubernetes-prow kubernetes-prow Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 10, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

Hi @azlkiniue. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow kubernetes-prow Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 10, 2026
@cpanato

cpanato commented Jul 10, 2026

Copy link
Copy Markdown
Member

/ok-to-test

@kubernetes-prow kubernetes-prow Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. needs-priority ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

schedule-builder does not move already EOL 1.33 to eol.yaml

2 participants