schedule-builder: don't skip adding to EOL if next release is not set#4462
schedule-builder: don't skip adding to EOL if next release is not set#4462azlkiniue wants to merge 1 commit into
Conversation
If the next release is not available, look for the latest previous patch available. Only skip if both are not available. The previous skip that was added to prevent a panic when the next release is not set still occurs after the EOL check. Also change EOL date value to use EndOfLifeDate instead of TargetDate. Signed-off-by: Ahmada Yusril <ahmadayusril@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: azlkiniue The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @azlkiniue! |
|
Hi @azlkiniue. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
What type of PR is this?
/kind bug
What this PR does / why we need it:
If the next release is not available, look for the latest previous patch available. Only skip if both are not available. The previous skip that was added to prevent a panic when the next release is not set still occurs after the EOL check. Also change EOL date value to use EndOfLifeDate instead of TargetDate.
Which issue(s) this PR fixes:
Fixes #4450
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?