Include details on the CSIVolumeSupportFSGroup feature gate#21671
Merged
k8s-ci-robot merged 1 commit intokubernetes:dev-1.19from Jul 16, 2020
Merged
Include details on the CSIVolumeSupportFSGroup feature gate#21671k8s-ci-robot merged 1 commit intokubernetes:dev-1.19from
k8s-ci-robot merged 1 commit intokubernetes:dev-1.19from
Conversation
Collaborator
|
Deploy preview for kubernetes-io-vnext-staging processing. Building with commit 0d6765d https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5f1079cbf0a08c0007680b5f |
k8s-ci-robot
added
cncf-cla: yes
Contributor
|
/milestone 1.19 |
k8s-ci-robot
added
the
sig/docs
Member
|
/milestone 1.19 |
tengqm
reviewed
Jun 13, 2020
| - `CSIMigrationGCEComplete`: Stops registering the GCE-PD in-tree plugin in kubelet and volume controllers and enables shims and translation logic to route volume operations from the GCE-PD in-tree plugin to PD CSI plugin. Requires CSIMigration and CSIMigrationGCE feature flags enabled and PD CSI plugin installed and configured on all nodes in the cluster. | ||
| - `CSIMigrationOpenStack`: Enables shims and translation logic to route volume operations from the Cinder in-tree plugin to Cinder CSI plugin. Supports falling back to in-tree Cinder plugin if a node does not have Cinder CSI plugin installed and configured. Requires CSIMigration feature flag enabled. | ||
| - `CSIMigrationOpenStackComplete`: Stops registering the Cinder in-tree plugin in kubelet and volume controllers and enables shims and translation logic to route volume operations from the Cinder in-tree plugin to Cinder CSI plugin. Requires CSIMigration and CSIMigrationOpenStack feature flags enabled and Cinder CSI plugin installed and configured on all nodes in the cluster. | ||
| - `CSIVolumeSupportFSGroup`: Allows CSIDrivers to use the `supportsFsGroup` field. This field controls where volumes created by a CSIDriver support volume ownership and permission modifications when these volumes are mounted. |
Contributor
There was a problem hiding this comment.
CSIVolumeSupportFSGroup sorts after CSIPersistentVolume; remember to adjust this to use the correct ordering.
Contributor
Author
There was a problem hiding this comment.
I've adjusted this to be whether instead of where, and corrected the ordering.
Contributor
|
/retitle [WIP] Include details on the CSIVolumeSupportFSGroup feature gate When ready @huffmanca please feel free to remove
from the PR description, and retitle again to remove the [WIP] marker as well. |
k8s-ci-robot
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
huffmanca
force-pushed
the
csi-driver-fsgroup-support
branch
from
874fa61 to
194ef0a
Compare
huffmanca
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
huffmanca
force-pushed
the
csi-driver-fsgroup-support
branch
2 times, most recently
from
ce24c7d to
fc615eb
Compare
Contributor
|
/sig storage |
k8s-ci-robot
added
the
sig/storage
Contributor
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
Contributor
|
Hi 👋 1.19 docs shadow here, |
Member
|
/lgtm |
k8s-ci-robot
added
the
approved
Member
|
/hold cancel |
k8s-ci-robot
added
needs-rebase
Member
|
@huffmanca Please rebase to get this PR merged |
Member
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
huffmanca
force-pushed
the
csi-driver-fsgroup-support
branch
from
fc615eb to
87658d4
Compare
k8s-ci-robot
added
size/XXL
huffmanca
force-pushed
the
csi-driver-fsgroup-support
branch
2 times, most recently
from
d3b2926 to
da221ae
Compare
k8s-ci-robot
added
size/XS
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: savitharaghunathan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
huffmanca
force-pushed
the
csi-driver-fsgroup-support
branch
from
da221ae to
0d6765d
Compare
Member
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Member
|
kubernetes/kubernetes#92001 has been merged! |
k8s-ci-robot
removed
the
do-not-merge/hold
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the documentation aspect for including the
fsGroupPolicyfeature currently planned for the 1.19 release.Work is being included in the kubernetes/kubernetes#92001 .