Skip to content

Add more description about HorizontalPodAutoscaler Object#53476

Open
CatherineF-dev wants to merge 1 commit intokubernetes:mainfrom
CatherineF-dev:patch-2
Open

Add more description about HorizontalPodAutoscaler Object#53476
CatherineF-dev wants to merge 1 commit intokubernetes:mainfrom
CatherineF-dev:patch-2

Conversation

@CatherineF-dev
Copy link
Copy Markdown
Contributor

@CatherineF-dev CatherineF-dev commented Nov 28, 2025

Description

Issue

Closes: #

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 28, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lmktfy for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Nov 28, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 28, 2025
@CatherineF-dev CatherineF-dev changed the title Update horizontal-pod-autoscale.md Add more description about HorizontalPodAutoscaler Object Nov 28, 2025
@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 28, 2025

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 0bf37c7
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/6928f21f081e81000873ba97
😎 Deploy Preview https://deploy-preview-53476--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@lmktfy
Copy link
Copy Markdown
Member

lmktfy commented Nov 29, 2025

/sig autoscaling

@k8s-ci-robot k8s-ci-robot added the sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. label Nov 29, 2025
stmcginnis
stmcginnis reviewed Dec 1, 2025
View reviewed changes
Comment thread content/en/docs/tasks/run-application/horizontal-pod-autoscale.md
[HorizontalPodAutoscaler Object](/docs/reference/generated/kubernetes-api/{{< param "version" >}}/#horizontalpodautoscaler-v2-autoscaling).

HorizontalPodAutoscaler Object contains Spec and Status.
The `Spec` contains 4 fields:
Copy link
Copy Markdown
Contributor

@stmcginnis stmcginnis Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sort of a nit, but when writing out numbers, it would be best to use the word:

Suggested change
The `Spec` contains 4 fields:
The `Spec` contains four fields:

Comment thread content/en/docs/tasks/run-application/horizontal-pod-autoscale.md
3. Metrics: scale based on what.
4. Behavior: ScaleUp and ScaleDown, which contains Stabilitzation Window and Policies.

The `Metrics` supports 4 different sources:
Copy link
Copy Markdown
Contributor

@stmcginnis stmcginnis Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

Comment thread content/en/docs/tasks/run-application/horizontal-pod-autoscale.md

| Metric Type | Source of Data | Logic Applied | Typical Example |
| :--- | :--- | :--- | :--- |
| **Resource** | CPU / RAM usage (Built-in) | Usage vs. Request % | Scale when CPU > 80% |
Copy link
Copy Markdown
Contributor

@stmcginnis stmcginnis Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another nit, but it doesn't feel right to me to have these in a different order than they are listed just prior to the table.

Maybe even alphabetize the list?

Comment thread content/en/docs/tasks/run-application/horizontal-pod-autoscale.md
| **External** | Outside the cluster | Absolute value | Scale when `pubsub_queue_length` > 1000 |


The `Status` contains 3 information:
Copy link
Copy Markdown
Contributor

@stmcginnis stmcginnis Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The `Status` contains 3 information:
The `Status` contains three pieces of information:

Comment thread content/en/docs/tasks/run-application/horizontal-pod-autoscale.md


The `Status` contains 3 information:
1. Replicas info: CurrentReplicas and DesiredReplicas
Copy link
Copy Markdown
Contributor

@stmcginnis stmcginnis Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. Replicas info: CurrentReplicas and DesiredReplicas
1. Replica info: CurrentReplicas and DesiredReplicas

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 18, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Dec 18, 2025

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-triage-robot
Copy link
Copy Markdown

k8s-triage-robot commented Mar 18, 2026

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 18, 2026
@k8s-triage-robot
Copy link
Copy Markdown

k8s-triage-robot commented Apr 17, 2026

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adrianmoisey adrianmoisey Awaiting requested review from adrianmoisey

@omerap12 omerap12 Awaiting requested review from omerap12

1 more reviewer

@stmcginnis stmcginnis stmcginnis left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@CatherineF-dev @k8s-ci-robot @lmktfy @k8s-triage-robot @stmcginnis