Add support for the collection:delete API action #523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 7-dev #523 +/- ##
==========================================
- Coverage 95.59% 91.16% -4.44%
==========================================
Files 32 32
Lines 1318 1392 +74
Branches 0 129 +129
==========================================
+ Hits 1260 1269 +9
- Misses 58 98 +40
- Partials 0 25 +25
Continue to review full report at Codecov.
|
Aschen
suggested changes
Jun 22, 2020
| <br/> | ||
|
|
||
| ```js | ||
| delete(index, collection, [options]); |
There was a problem hiding this comment.
What kind of options can you pass? Also you should add this to the arguments table
| code: true | ||
| type: page | ||
| title: delete | ||
| description: Delete a collection |
There was a problem hiding this comment.
Suggested change
| description: Delete a collection | |
| description: Deletes a collection |
|
|
||
| ## Resolves | ||
|
|
||
| Resolves if the collection is successfully delete. |
There was a problem hiding this comment.
Suggested change
| Resolves if the collection is successfully delete. | |
| Resolves if the collection is successfully deleted. |
| template: default | ||
| expected: Success | ||
|
|
||
| sdk: js |
There was a problem hiding this comment.
You can remove this line and the one below, we don't need them anymore
alexandrebouthinon
approved these changes
Jun 24, 2020
Aschen
suggested changes
Jul 1, 2020
src/controllers/Collection.js
Outdated
| action: 'delete' | ||
| }; | ||
| return this.query(request) | ||
| .then(response => response.result); |
There was a problem hiding this comment.
IMHO this should return undefined
rolljee
approved these changes
Jul 1, 2020
Aschen
approved these changes
Jul 1, 2020
src/controllers/Collection.js
Outdated
| action: 'delete' | ||
| }; | ||
| return this.query(request) | ||
| .then(undefined); |
There was a problem hiding this comment.
Then then method take a callback as a parameter, passing undefined will result to a TypeError.
The promise resolved value will be this callback return value
Suggested change
| .then(undefined); | |
| .then(() => undefined); |
scottinet
changed the title
…t into collection-delete
Aschen
approved these changes
Jul 30, 2020
Aschen
added a commit
that referenced
this pull request
Aug 18, 2020
# [7.4.0](https://github.com/kuzzleio/sdk-javascript/releases/tag/7.4.0) (2020-08-18) #### New features - [ [#542](#542) ] Finalize typescript support ([Aschen](https://github.com/Aschen)) - [ [#529](#529) ] Add typescript support for protocols ([Aschen](https://github.com/Aschen)) #### Enhancements - [ [#541](#541) ] Add meaningful stacktrace ([Aschen](https://github.com/Aschen)) - [ [#537](#537) ] Add typescript support realtime ([Aschen](https://github.com/Aschen)) - [ [#531](#531) ] Add typescript support for Index and Collection controllers ([Aschen](https://github.com/Aschen)) - [ [#530](#530) ] Add typescript support for search results ([Aschen](https://github.com/Aschen)) - [ [#523](#523) ] Add support for the collection:delete API action ([morgandruesne](https://github.com/morgandruesne)) ---
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR add the delete function and test for the Collection Controller