Add typescript support for search results #530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 22, 2020 10:29
Aschen
commented
Jul 22, 2020
| import { JSONObject } from '../../utils/interfaces'; | ||
|
|
||
| class SpecificationsSearchResult extends SearchResultBase { | ||
| export class SpecificationsSearchResult extends SearchResultBase<JSONObject> { |
There was a problem hiding this comment.
I know I should have created a proper Specification interface but I'm lazy to do it since I doubt someone is using this and we need a refactor of this module.
The JSONObject type works like a POJO
Codecov Report
@@ Coverage Diff @@
## 7-dev #530 +/- ##
========================================
Coverage ? 91.18%
========================================
Files ? 32
Lines ? 1395
Branches ? 133
========================================
Hits ? 1272
Misses ? 98
Partials ? 25
Continue to review full report at Codecov.
|
scottinet
approved these changes
Aug 4, 2020
added 2 commits
August 4, 2020 15:19
xbill82
reviewed
Aug 11, 2020
| this._scrollAction = 'scroll'; | ||
| Reflect.defineProperty(this, '_controller', { | ||
| value: request.controller, | ||
| writable: true |
There was a problem hiding this comment.
Because in the SpecificationSearchResult class we overload the controller with collection
xbill82
approved these changes
Aug 11, 2020
Aschen
added a commit
that referenced
this pull request
Aug 18, 2020
# [7.4.0](https://github.com/kuzzleio/sdk-javascript/releases/tag/7.4.0) (2020-08-18) #### New features - [ [#542](#542) ] Finalize typescript support ([Aschen](https://github.com/Aschen)) - [ [#529](#529) ] Add typescript support for protocols ([Aschen](https://github.com/Aschen)) #### Enhancements - [ [#541](#541) ] Add meaningful stacktrace ([Aschen](https://github.com/Aschen)) - [ [#537](#537) ] Add typescript support realtime ([Aschen](https://github.com/Aschen)) - [ [#531](#531) ] Add typescript support for Index and Collection controllers ([Aschen](https://github.com/Aschen)) - [ [#530](#530) ] Add typescript support for search results ([Aschen](https://github.com/Aschen)) - [ [#523](#523) ] Add support for the collection:delete API action ([morgandruesne](https://github.com/morgandruesne)) ---
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds Typescript support for SearchResult classes