Add typescript support for Index and Collection controllers #531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 7-dev #531 +/- ##
==========================================
- Coverage 89.68% 88.50% -1.18%
==========================================
Files 32 32
Lines 1406 1427 +21
Branches 225 242 +17
==========================================
+ Hits 1261 1263 +2
- Misses 99 117 +18
- Partials 46 47 +1
Continue to review full report at Codecov.
|
scottinet
suggested changes
Aug 10, 2020
src/utils/interfaces.ts
Outdated
| * | ||
| * @see https://docs.kuzzle.io/core/2/guides/essentials/database-mappings/#dynamic-mapping-policy | ||
| */ | ||
| dynamic?: 'true' | 'false' | 'strict' |
There was a problem hiding this comment.
As per kuzzleio/kuzzle#1745, shouldn't we also accept boolean values?
Co-authored-by: Sébastien Cottinet <scottinet@protonmail.com>
…kuzzleio/sdk-javascript into add-typescript-support-index-collection
scottinet
suggested changes
Aug 10, 2020
Co-authored-by: Sébastien Cottinet <scottinet@protonmail.com>
scottinet
approved these changes
Aug 10, 2020
xbill82
reviewed
Aug 11, 2020
| ## Usage | ||
|
|
||
| :::: tabs | ||
| ::: tab yourTabName |
There was a problem hiding this comment.
does this really render to yourTabName and anotherTab, or is this just a copy-paste error?
There was a problem hiding this comment.
It was an experiment to include TS snippet but it will be done later since it's a lot of work
(removed)
added 2 commits
August 11, 2020 11:54
…kuzzleio/sdk-javascript into add-typescript-support-index-collection
xbill82
approved these changes
Aug 11, 2020
Aschen
added a commit
that referenced
this pull request
Aug 18, 2020
# [7.4.0](https://github.com/kuzzleio/sdk-javascript/releases/tag/7.4.0) (2020-08-18) #### New features - [ [#542](#542) ] Finalize typescript support ([Aschen](https://github.com/Aschen)) - [ [#529](#529) ] Add typescript support for protocols ([Aschen](https://github.com/Aschen)) #### Enhancements - [ [#541](#541) ] Add meaningful stacktrace ([Aschen](https://github.com/Aschen)) - [ [#537](#537) ] Add typescript support realtime ([Aschen](https://github.com/Aschen)) - [ [#531](#531) ] Add typescript support for Index and Collection controllers ([Aschen](https://github.com/Aschen)) - [ [#530](#530) ] Add typescript support for search results ([Aschen](https://github.com/Aschen)) - [ [#523](#523) ] Add support for the collection:delete API action ([morgandruesne](https://github.com/morgandruesne)) ---
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add typescript support for Index and Collection controllers
Other changes
collection:updateandcollection:createmethods (new syntax withmappingsandsettings)undefinedinstead of some useless{ acknowledged: true }. Since this was undocumented it's not a breaking changeBoyscout