Add typescript support for protocols #529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 7-dev #529 +/- ##
==========================================
- Coverage 91.18% 89.68% -1.50%
==========================================
Files 32 32
Lines 1395 1406 +11
Branches 133 225 +92
==========================================
- Hits 1272 1261 -11
- Misses 98 99 +1
- Partials 25 46 +21
Continue to review full report at Codecov.
|
added 2 commits
July 31, 2020 11:22
scottinet
suggested changes
Aug 6, 2020
Co-authored-by: Sébastien Cottinet <scottinet@protonmail.com>
Co-authored-by: Sébastien Cottinet <scottinet@protonmail.com>
…o/sdk-javascript into add-typescript-support-protocols
scottinet
approved these changes
Aug 6, 2020
xbill82
reviewed
Aug 11, 2020
xbill82
reviewed
Aug 11, 2020
xbill82
approved these changes
Aug 11, 2020
added 2 commits
August 11, 2020 11:40
…o/sdk-javascript into add-typescript-support-protocols
Aschen
added a commit
that referenced
this pull request
Aug 18, 2020
# [7.4.0](https://github.com/kuzzleio/sdk-javascript/releases/tag/7.4.0) (2020-08-18) #### New features - [ [#542](#542) ] Finalize typescript support ([Aschen](https://github.com/Aschen)) - [ [#529](#529) ] Add typescript support for protocols ([Aschen](https://github.com/Aschen)) #### Enhancements - [ [#541](#541) ] Add meaningful stacktrace ([Aschen](https://github.com/Aschen)) - [ [#537](#537) ] Add typescript support realtime ([Aschen](https://github.com/Aschen)) - [ [#531](#531) ] Add typescript support for Index and Collection controllers ([Aschen](https://github.com/Aschen)) - [ [#530](#530) ] Add typescript support for search results ([Aschen](https://github.com/Aschen)) - [ [#523](#523) ] Add support for the collection:delete API action ([morgandruesne](https://github.com/morgandruesne)) ---
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Convert protocols classes to TS
Other changes
sslConnectionis deprecated forssland the value istrueby default for port443and7443error.internalerror who contain the original WS connect error and put the info in the message instead