Skip to content

Conversation

Aschen
Copy link
Contributor

@Aschen Aschen commented Aug 13, 2020

What does this PR do?

Exports TS classes

How should this be manually tested?

  • Step 1 : npm run build && npm pack
  • Step 2 : Create a new project with npm init and add the .tgz file generated in the previous step as dependency
  • Step 3 : Create a test.ts file and try to import the SDK from kuzzle-sdk
    ...

Other changes

  • add more types to Kuzzle

@codecov
Copy link

codecov bot commented Aug 13, 2020

Codecov Report

Merging #542 into 7-dev will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##            7-dev     #542   +/-   ##
=======================================
  Coverage   88.34%   88.34%           
=======================================
  Files          32       32           
  Lines        1441     1441           
  Branches      249      250    +1     
=======================================
  Hits         1273     1273           
  Misses        119      119           
  Partials       49       49           
Impacted Files Coverage Δ
src/core/KuzzleEventEmitter.ts 90.00% <ø> (ø)
src/protocols/Http.ts 85.09% <ø> (ø)
src/protocols/WebSocket.ts 90.76% <ø> (ø)
src/Kuzzle.ts 87.34% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 654d9e3...afb7abd. Read the comment docs.

@xbill82 xbill82 merged commit 4fbe15d into 7-dev Aug 18, 2020
@xbill82 xbill82 deleted the finalize-typescript-support branch August 18, 2020 10:06
This was referenced Aug 18, 2020
Aschen added a commit that referenced this pull request Aug 18, 2020
# [7.4.0](https://github.com/kuzzleio/sdk-javascript/releases/tag/7.4.0) (2020-08-18)


#### New features

- [ [#542](#542) ] Finalize typescript support   ([Aschen](https://github.com/Aschen))
- [ [#529](#529) ] Add typescript support for protocols   ([Aschen](https://github.com/Aschen))

#### Enhancements

- [ [#541](#541) ] Add meaningful stacktrace   ([Aschen](https://github.com/Aschen))
- [ [#537](#537) ] Add typescript support realtime   ([Aschen](https://github.com/Aschen))
- [ [#531](#531) ] Add typescript support for Index and Collection controllers   ([Aschen](https://github.com/Aschen))
- [ [#530](#530) ] Add typescript support for search results   ([Aschen](https://github.com/Aschen))
- [ [#523](#523) ] Add support for the collection:delete API action   ([morgandruesne](https://github.com/morgandruesne))
---
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants