Show tracked regions in Spotlight - #210
Merged
Merged
Conversation
This was referenced Aug 9, 2026
kyleve
force-pushed
the
codex/explore-spotlight
branch
3 times, most recently
from
August 9, 2026 05:24
22e2437 to
8b11267
Compare
kyleve
force-pushed
the
codex/explore-spotlight
branch
from
August 9, 2026 05:59
8b11267 to
d2172e5
Compare
kyleve
added a commit
that referenced
this pull request
Aug 9, 2026
## Summary - add a searchable “Share & Evidence” explorer for the system share extension, evidence composition, and attachment archive - show the latest real evidence metadata when available, with explicit loading/failure and illustrative empty states - link directly to the existing Attachments archive without duplicating its behavior - add localized, accessible previews and a complete device/appearance snapshot matrix ## Testing - `./test WhereUITests` (419 tests passed) - focused Share & Evidence and Settings snapshot matrices passed - included in the final full 42-suite snapshot verification ## Stack Third PR in five-PR GitHub Stack; based on [#210](#210), followed by [#212](#212).
cursor Bot
pushed a commit
that referenced
this pull request
Aug 9, 2026
Opens two new area backlogs, per the root placement rule that an area gets its own file the first time it has an item. Ledger/TODOs.md -- its first audit. The module is in good shape: 16 sources / 13 test files, Swift Testing throughout, a single LoadState enum rather than parallel loading/error/value fields, typed DashboardError -> LoadError mapping that never swallows a failure, a failed refresh that keeps prior data and surfaces staleness, no secrets in its JSON (pasted token in the Keychain, auto token read-only from Cursor's own store), no token values in log strings, and its docs correctly credit PeriscopeCore rather than the deleted LogKit. Filed three P2s: a Calendar.current default that also violates the no-Core-parameter- defaults rule, three 1:1 test gaps, and the deliberate absence of an app-shell test bundle. Recorded that Bumper Bowling does not cover Ledger -- verified against BumperBowling.swift, whose Included list is Where-only. Shared/Flyover/TODOs.md -- one P2. Its engine is well covered; the interactive surfaces are not, and the fix shape is more image cases, not hosting smoke tests. Filed at root: ./test cannot run the macOS Ledger bundle at all -- no reference to Ledger or a macOS destination in 869 lines -- while root AGENTS.md states it is the only way to run tests. The skill and LedgerCore/AGENTS.md both document the tuist carve-out, so the always-applied root rule contradicted both. Sharpened two host items rather than restating them: the WhereIntents perform() gap is half closed (AGENTS.md now explains the framework trap; the README still implies full coverage), and PR #210 shipped RegionSpotlightIndexer with no test of its own -- RegionEntityTests covers its input, which is easy to mistake for coverage of the indexer. Corrected a doc claim precisely: RegionViewer/README.md describes Source mode as decoding a monolithic us-states.geojson, but buildSourceOutlines walks the 54 bundled per-region files. The monolith does still exist -- as a build-time input under RegionKit/Tools/source -- so the README describes the pipeline's input as if it were the app's data. Rejected a candidate high-severity finding: StaggeredReveal.swift:85 sets \.isCapturingSnapshot to true, which would make real users get capture stand-ins, but it is inside #if DEBUG in a #Preview and never ships. Validation: docs only. swiftformat --lint and attribution --check pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
./test WhereUITests(419 tests passed)Stack
Second PR in five-PR GitHub Stack; based on #204, followed by #211.
Stack created with GitHub Stacks CLI • Give Feedback 💬