feat(l1,l2): name rayon threads for easier debugging #5269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds unique naming to Rayon worker threads to facilitate debugging and performance analysis. Previously, Rayon threads inherited the name of the calling thread, making it difficult to identify which threads were experiencing contention.
- Initializes the global Rayon thread pool with custom thread names
- Adds rayon dependency to the ethrex binary crate
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| cmd/ethrex/ethrex.rs | Adds Rayon thread pool initialization with custom naming pattern in the main function |
| cmd/ethrex/Cargo.toml | Adds rayon workspace dependency to the ethrex binary crate |
| Cargo.lock | Updates dependency graph to include rayon for the ethrex binary |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| rayon::ThreadPoolBuilder::default() | ||
| .thread_name(|i| format!("rayon-worker-{i}")) | ||
| .build_global() | ||
| .expect("failed to build rayon threadpool"); |
There was a problem hiding this comment.
The error message uses 'threadpool' but it should be 'thread pool' (two words) for consistency with the standard terminology.
Suggested change
| .expect("failed to build rayon threadpool"); | |
| .expect("failed to build rayon thread pool"); |
Lines of code reportTotal lines added: Detailed view |
MegaRedHand
approved these changes
Nov 11, 2025
jrchatruc
approved these changes
Nov 11, 2025
xqft
pushed a commit
that referenced
this pull request
Nov 11, 2025
**Motivation** Rayon currently inherits the name of the thread that calls it first, which creates confusion when, for example, one tries to see which threads incur the most contention. **Description** Initialize the global thread pool on init to ensure the Rayon workers each have a unique name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Rayon currently inherits the name of the thread that calls it first, which creates
confusion when, for example, one tries to see which threads incur the most contention.
Description
Initialize the global thread pool on init to ensure the Rayon workers each have a
unique name.