Skip to content

feat(l1,l2): name rayon threads for easier debugging #5269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2025
Merged

feat(l1,l2): name rayon threads for easier debugging #5269

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions cmd/ethrex/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ serde_json.workspace = true
tokio = { workspace = true, features = ["full"] }
anyhow = "1.0.86"
rand = "0.8.5"
rayon.workspace = true
local-ip-address = "0.6"
tokio-util.workspace = true
lazy_static.workspace = true
Expand Down
5 changes: 5 additions & 0 deletions cmd/ethrex/ethrex.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,11 @@ async fn server_shutdown(
async fn main() -> eyre::Result<()> {
let CLI { opts, command } = CLI::parse();

rayon::ThreadPoolBuilder::default()
.thread_name(|i| format!("rayon-worker-{i}"))
.build_global()
.expect("failed to build rayon threadpool");
Copy link

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error message uses 'threadpool' but it should be 'thread pool' (two words) for consistency with the standard terminology.

Suggested change
.expect("failed to build rayon threadpool");
.expect("failed to build rayon thread pool");

Copilot uses AI. Check for mistakes.

if let Some(subcommand) = command {
return subcommand.run(&opts).await;
}
Expand Down
Loading