Skip to content

fix(tally): disclose unallocated outstandings - #128

Merged
lamemustafa merged 7 commits into
masterfrom
tapish-codex/on-account-visibility
Aug 4, 2026
Merged

fix(tally): disclose unallocated outstandings#128
lamemustafa merged 7 commits into
masterfrom
tapish-codex/on-account-visibility

Conversation

@lamemustafa

Copy link
Copy Markdown
Owner

Partially addresses #116’s shipped voucher-path gap.

  • Retains On Account in receivable/payable totals but exposes it separately.
  • Excludes it from bill-only ageing/counts and reports no oldest bill when applicable.
  • Explains the existing fail-closed opening-balance coverage result.

No Tally request profile, runtime dispatch, endpoint, credential handling, or native-report authority changed. This does not close #116’s outstanding native-report/version questions.

Validation: pnpm build; focused Rust outstandings tests; Clippy; regression mutation check.

Rollback: revert 5ba3bc6. No migration or source-state impact.

@lamemustafa
lamemustafa marked this pull request as ready for review August 4, 2026 09:36

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5ba3bc6840

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src-tauri/crates/bridge-tally-protocol/src/outstandings/compute.rs Outdated
Comment thread src-tauri/crates/bridge-tally-protocol/src/outstandings/compute.rs Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a709dbc04a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src-tauri/crates/bridge-tally-protocol/src/outstandings/compute.rs
Comment thread src-tauri/crates/bridge-tally-protocol/src/outstandings/compute.rs

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: be2eff4f62

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src-tauri/crates/bridge-tally-protocol/src/outstandings/model.rs

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 86251f29f0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src-tauri/crates/bridge-tally-protocol/src/outstandings/compute.rs
Comment thread src-tauri/crates/bridge-tally-protocol/src/outstandings/compute.rs Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 401e5c00bc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src-tauri/src/tally/runtime.rs
@lamemustafa
lamemustafa merged commit 3066447 into master Aug 4, 2026
11 checks passed
@lamemustafa
lamemustafa deleted the tapish-codex/on-account-visibility branch August 4, 2026 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tally: Bridge's answers depend on Tally configuration, and the worst failures are silent

1 participant