Skip to content

feat(tally): clarify readiness workflow - #129

Merged
lamemustafa merged 13 commits into
masterfrom
tapish-codex/tally-readiness-ux
Aug 6, 2026
Merged

feat(tally): clarify readiness workflow#129
lamemustafa merged 13 commits into
masterfrom
tapish-codex/tally-readiness-ux

Conversation

@lamemustafa

Copy link
Copy Markdown
Owner

Functional summary

Replaces the duplicated Tally Setup hierarchy with one evidence-led readiness path: check local Tally, choose a company, then save its reviewed scope. The compatibility-only company listing is now secondary. When #128 withholds outstandings for unallocated direct postings, the UI identifies that as a product boundary and replaces Refresh with a neutral link to view readiness.

Source issue/rectify reference

Why

The prior screen repeated endpoint, identity, and operator state across several competing panels and actions before the operator could identify the next safe step. The new order retains the same native commands and evidence boundary while making the path legible.

Testing

  • node --experimental-strip-types --test scripts/*.test.mjs (17 passing)
  • pnpm exec tsc --noEmit
  • pnpm exec vite build
  • Browser-checked the no-Tally first-run state at desktop and 390 px width. The browser preview has no native Tauri bridge, so native command invocation was not claimed as browser proof.
  • Completed checklist line: Errors are actionable without exposing sensitive values
  • Native Windows/macOS: not affected; this is React/CSS only.

Compatibility and rollback

  • Migration/sync compatibility impact: none; no Tally request shape, native command, persisted model, or sync behavior changed.
  • Rollback procedure: revert commit 029ce32; the prior setup presentation is restored without data migration.
  • Destructive database migration: no.

Security impact

  • DSC/Tally/credential impact: presentation-only around existing read-only Tally setup. No endpoint validation, credential handling, native request, or sensitive diagnostics behavior changed.
  • Security-focused reviewer comment: not required; no DSC or credential-path change.

Checklist

  • Security implications reviewed; the fail-closed fix(tally): disclose unallocated outstandings #128 reason remains truthful and does not encourage a futile retry.
  • Migration compatibility and rollback impact documented.
  • Error handling paths remain actionable; the special boundary is explicit.
  • No debug logs or sensitive values added.
  • No personal/customer data, certificate output, local usernames, or developer-specific paths added.
  • Tests use synthetic/no-live data.
  • No third-party code or assets added; existing Lucide icons only.
  • Branching aligns with managed-git policy.

@lamemustafa
lamemustafa marked this pull request as ready for review August 5, 2026 07:03

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 029ce32aa3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/TallyReadinessFlow.tsx Outdated
Comment thread src/main.tsx Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8d734cab95

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/TallyReadinessFlow.tsx Outdated
Comment thread docs/tally/compatibility/compatibility-surface.json Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 899197ec12

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/TallyReadinessFlow.tsx Outdated
Comment thread src/main.tsx Outdated
Comment thread docs/tally/compatibility/compatibility-surface.json Outdated
* feat(tally): simplify company setup flow

* fix(tally): clarify safe setup and report boundaries
@lamemustafa
lamemustafa enabled auto-merge (squash) August 5, 2026 13:49

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0925464ffa

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/tally-company-selection.ts Outdated
Comment thread src/main.tsx
Comment thread src/main.tsx
Comment thread src/main.tsx Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8e2d5968f3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/main.tsx Outdated
Comment thread src/main.tsx
Comment thread src/main.tsx Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a2461d3c9b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docs/tally/compatibility/compatibility-surface.json Outdated
Comment thread src/main.tsx

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ee46f58908

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/main.tsx Outdated
Comment thread src/main.tsx Outdated
Comment thread src/main.tsx

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1246346dde

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/main.tsx Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e58a9c9a7b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/main.tsx Outdated
Comment thread src/outstandings-copy.ts
Comment thread src/tally-error-copy.ts
Comment thread src/main.tsx Outdated
Comment thread src/main.tsx Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 410e25c52d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/OutstandingsScreen.tsx Outdated
Comment thread src/main.tsx Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9c6a718204

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/styles.css

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d7ab22fb1f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/main.tsx Outdated
@lamemustafa
lamemustafa merged commit cb43608 into master Aug 6, 2026
11 checks passed
@lamemustafa
lamemustafa deleted the tapish-codex/tally-readiness-ux branch August 6, 2026 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant