Flush the pause buffer when the adb stream ends - #68
Merged
Conversation
The pause buffer (lines held while paused) only flushed on the next non-paused line. If the stream ended while still paused — device disconnects, or a finite `logcat -d` dump finishes mid-pause — the buffered lines were dropped with the reader thread instead of delivered. Drain the buffer to the channel on EOF.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary (regression caught in self-review)
The pause buffer added in the "buffer logs while paused" change only flushed on the next non-paused line. If the adb stream ended while still paused — the device disconnects, or a finite
logcat -ddump finishes mid-pause — the buffered lines were dropped with the reader thread instead of delivered (silent data loss).Drain the buffer to the channel on EOF, before signaling
ended.Test plan
buffered_lines_flush_when_stream_ends_while_paused— pause before the child emits, child exits, all buffered lines are delivered (deterministic, 3× green)