removed useless reinitialisation of time grid (thanks to @amaggiulli) - #93
removed useless reinitialisation of time grid (thanks to @amaggiulli)#93klausspanderen wants to merge 1 commit into
Conversation
|
Credit to @amaggiulli for spotting it. |
|
thanks, I've changed it. On Friday, May 20, 2016 01:02:25 PM Francois Botha wrote: Credit to @amaggiulli[1] for spotting it. [1] https://github.com/amaggiulli |
|
Please also have a look at #92 . That's @amaggiulli 's alternative solution. I'm just curious why it's possible to remove all those variables and still have the tests pass. Aren't they used? |
|
I'd say one grid is 0, 1, 2, 3, 4 ... and the other (the "correct" one) is slightly different at some points (differing maybe by +-1/365, +-2/365 or the like), but this is swallowed by the MC tolerance at the end. |
|
Let's close this PR as we have alternative solutions in the line |
No description provided.