[Merged by Bors] - chore: adaptations for nightly-2025-10-29 #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hlib4-nightly-testing into nightly-testing
kbuzzard
reviewed
Nov 2, 2025
| wlog h : p.natDegree ≤ n generalizing n | ||
| · refine Nat.decreasingInduction' (fun n hn _ ih ↦ ?_) (le_of_not_ge h) ?_ | ||
| · rw [coeff_divByMonic_X_sub_C_rec, ih, eq_comm, Icc_eq_cons_Ioc (Nat.succ_le.mpr hn), | ||
| · rw [coeff_divByMonic_X_sub_C_rec, ih, eq_comm, Icc_eq_cons_Ioc (Nat.succ_le_iff.mpr hn), |
Member
There was a problem hiding this comment.
Suggested change
| · rw [coeff_divByMonic_X_sub_C_rec, ih, eq_comm, Icc_eq_cons_Ioc (Nat.succ_le_iff.mpr hn), | |
| · rw [coeff_divByMonic_X_sub_C_rec, ih, eq_comm, Icc_eq_cons_Ioc (Nat.succ_le_of_lt hn), |
kbuzzard
reviewed
Nov 2, 2025
| rw [add_comm]; exact (mem_Icc.mp hi).1 | ||
| · exact this _ le_rfl | ||
| rw [Icc_eq_empty (Nat.lt_succ.mpr h).not_ge, sum_empty] | ||
| rw [Icc_eq_empty (Nat.lt_succ_iff.mpr h).not_ge, sum_empty] |
Member
There was a problem hiding this comment.
Suggested change
| rw [Icc_eq_empty (Nat.lt_succ_iff.mpr h).not_ge, sum_empty] | |
| rw [Icc_eq_empty (Nat.lt_succ_of_le h).not_ge, sum_empty] |
kbuzzard
reviewed
Nov 2, 2025
| lemma eval_homogenize {p : K[X]} {n : ℕ} (hn : p.natDegree ≤ n) (x : Fin 2 → K) (hx : x 1 ≠ 0) : | ||
| MvPolynomial.eval x (p.homogenize n) = p.eval (x 0 / x 1) * x 1 ^ n := by | ||
| simp only [homogenize, Polynomial.eval_eq_sum_range' (Nat.lt_succ.mpr hn), | ||
| simp only [homogenize, Polynomial.eval_eq_sum_range' (Nat.lt_succ_iff.mpr hn), |
Member
There was a problem hiding this comment.
Suggested change
| simp only [homogenize, Polynomial.eval_eq_sum_range' (Nat.lt_succ_iff.mpr hn), | |
| simp only [homogenize, Polynomial.eval_eq_sum_range' (Nat.lt_succ_of_le hn), |
kbuzzard
reviewed
Nov 2, 2025
kbuzzard
reviewed
Nov 2, 2025
kbuzzard
reviewed
Nov 2, 2025
kbuzzard
reviewed
Nov 2, 2025
kbuzzard
reviewed
Nov 2, 2025
kbuzzard
reviewed
Nov 2, 2025
kbuzzard
reviewed
Nov 2, 2025
kbuzzard
reviewed
Nov 2, 2025
kbuzzard
approved these changes
Nov 2, 2025
Member
kbuzzard
left a comment
kbuzzard
left a comment
There was a problem hiding this comment.
I've gone through all the diff. I think writing Nat.foo.mp or Nat.foo.2 is daft when foo is actually proved as \<one_way, the_other_way\>, not least because the individual implication lemmas typically have names which are at least as explanatory as the iff ones. I changed the first one myself and pushed, and then realised there were 10+ others so I've left them for someone else to decide.
There's a merge conflict but other than that this looks ready to go.
kbuzzard
reviewed
Nov 2, 2025
|
bors merge |
|
Build failed: |
|
bors merge |
|
Pull request successfully merged into bump/v4.26.0. Build succeeded: |
mathlib-bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.