[Merged by Bors] - chore(SimpleGraph/Extremal): update IsExtremal docstrings#31372
Closed
mitchell-horner wants to merge 1 commit into
Closed
[Merged by Bors] - chore(SimpleGraph/Extremal): update IsExtremal docstrings#31372mitchell-horner wants to merge 1 commit into
IsExtremal docstrings#31372mitchell-horner wants to merge 1 commit into
Conversation
PR summary ec382b5a79Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
2 tasks
mathlib-bors Bot
pushed a commit
that referenced
this pull request
Nov 8, 2025
Update docstrings for `IsExtremal` to clarify definition.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
IsExtremal docstringsIsExtremal docstrings
thorimur
pushed a commit
to thorimur/mathlib4
that referenced
this pull request
Nov 16, 2025
…er-community#31372) Update docstrings for `IsExtremal` to clarify definition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update docstrings for
IsExtremalto clarify definition.See #28719 (comment).
The docstring left out the fact that the maximum is taken on simple graphs with fixed vertices. This is implicit in the definition of
SimpleGraph. The docstring now explicitly notes this to avoid confusion and align with the definition you might read in a textbook somewhere.