Skip to content

[Merged by Bors] - perf(AlgebraicGeometry/EllipticCurve/Affine/Point): help elaborator#39124

Closed
kbuzzard wants to merge 2 commits into
leanprover-community:masterfrom
kbuzzard:kbuzzard-elliptic-curve-speedup
Closed

[Merged by Bors] - perf(AlgebraicGeometry/EllipticCurve/Affine/Point): help elaborator#39124
kbuzzard wants to merge 2 commits into
leanprover-community:masterfrom
kbuzzard:kbuzzard-elliptic-curve-speedup

Conversation

@kbuzzard
Copy link
Copy Markdown
Member

@kbuzzard kbuzzard commented May 9, 2026

For some reason Lean likes it much better when we explicitly tell it W, even though it can be figured out through elaboration. Typeclass inference goes off on a completely unnecessary wild goose chase before this figuring-out is done, for some reason.


Open in Gitpod

See #mathlib4 > Field (FunctionField ?m.19) @ 💬

@github-actions github-actions Bot added the t-algebraic-geometry Algebraic geometry label May 9, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 9, 2026

PR summary 043e9e0413

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.


No changes to strong technical debt.
No changes to weak technical debt.

@kbuzzard
Copy link
Copy Markdown
Member Author

kbuzzard commented May 9, 2026

!radar

@leanprover-radar
Copy link
Copy Markdown

leanprover-radar commented May 9, 2026

Benchmark results for d5965ec against 043e9e0 are in. No significant results found. @kbuzzard

  • build//instructions: -13.5G (-0.01%)

Medium changes (1✅)

  • build/module/Mathlib.AlgebraicGeometry.EllipticCurve.Affine.Point//instructions: -15.5G (-15.15%)

Copy link
Copy Markdown
Collaborator

@Multramate Multramate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread Mathlib/AlgebraicGeometry/EllipticCurve/Affine/Point.lean Outdated
Comment thread Mathlib/AlgebraicGeometry/EllipticCurve/Affine/Point.lean Outdated
@joelriou
Copy link
Copy Markdown
Contributor

Thanks!

bors merge

mathlib-bors Bot pushed a commit that referenced this pull request May 10, 2026
…39124)

For some reason Lean likes it much better when we explicitly tell it `W`, even though it can be figured out through elaboration. Typeclass inference goes off on a completely unnecessary wild goose chase before this figuring-out is done, for some reason.
@mathlib-triage mathlib-triage Bot added the ready-to-merge This PR has been sent to bors. label May 10, 2026
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors Bot commented May 10, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title perf(AlgebraicGeometry/EllipticCurve/Affine/Point): help elaborator [Merged by Bors] - perf(AlgebraicGeometry/EllipticCurve/Affine/Point): help elaborator May 10, 2026
@mathlib-bors mathlib-bors Bot closed this May 10, 2026
yuanyi-350 pushed a commit to yuanyi-350/yuanyi_mathlib4 that referenced this pull request May 18, 2026
…eanprover-community#39124)

For some reason Lean likes it much better when we explicitly tell it `W`, even though it can be figured out through elaboration. Typeclass inference goes off on a completely unnecessary wild goose chase before this figuring-out is done, for some reason.
mathlib-bors Bot pushed a commit that referenced this pull request May 22, 2026
I noticed typeclass inference being slow to infer this input, so let's try making it explicit.

This is a way of removing the `(W := W)` hack introduced in #39124 .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-algebraic-geometry Algebraic geometry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants