[Merged by Bors] - perf(AlgebraicGeometry/EllipticCurve/Affine/Point): help elaborator#39124
Closed
kbuzzard wants to merge 2 commits into
Closed
[Merged by Bors] - perf(AlgebraicGeometry/EllipticCurve/Affine/Point): help elaborator#39124kbuzzard wants to merge 2 commits into
kbuzzard wants to merge 2 commits into
Conversation
PR summary 043e9e0413Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
Member
Author
|
!radar |
|
Benchmark results for d5965ec against 043e9e0 are in. No significant results found. @kbuzzard
Medium changes (1✅)
|
Multramate
approved these changes
May 9, 2026
kbuzzard
commented
May 9, 2026
Contributor
|
Thanks! bors merge |
mathlib-bors Bot
pushed a commit
that referenced
this pull request
May 10, 2026
…39124) For some reason Lean likes it much better when we explicitly tell it `W`, even though it can be figured out through elaboration. Typeclass inference goes off on a completely unnecessary wild goose chase before this figuring-out is done, for some reason.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
yuanyi-350
pushed a commit
to yuanyi-350/yuanyi_mathlib4
that referenced
this pull request
May 18, 2026
…eanprover-community#39124) For some reason Lean likes it much better when we explicitly tell it `W`, even though it can be figured out through elaboration. Typeclass inference goes off on a completely unnecessary wild goose chase before this figuring-out is done, for some reason.
mathlib-bors Bot
pushed a commit
that referenced
this pull request
May 22, 2026
I noticed typeclass inference being slow to infer this input, so let's try making it explicit. This is a way of removing the `(W := W)` hack introduced in #39124 .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason Lean likes it much better when we explicitly tell it
W, even though it can be figured out through elaboration. Typeclass inference goes off on a completely unnecessary wild goose chase before this figuring-out is done, for some reason.See #mathlib4 > Field (FunctionField ?m.19) @ 💬