[Merged by Bors] - perf: make Field input to ClassGroup.mk explicit#39685
[Merged by Bors] - perf: make Field input to ClassGroup.mk explicit#39685kbuzzard wants to merge 3 commits into
Conversation
Passes the field of fractions `K` explicitly at every `ClassGroup.mk` application, following the previous commit that made `K` an explicit argument. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
PR summary 0b683b8515Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
|
!radar |
|
Benchmark results for 0b683b8 against c669471 are in. No significant results found. @kbuzzard
Small changes (1✅, 2🟥)
|
|
The 14G decrease in instructions is little more than noise -- the point of this PR is that #39124 and #mathlib4 > Field (FunctionField ?m.19) @ 💬 shows that we have a footgun and this PR is an attempt to make it less likely to go off. Note that if you fill in the now-explicit input field with is not great in Lean 4, and making K explicit is a bit better. |
|
bors merge |
I noticed typeclass inference being slow to infer this input, so let's try making it explicit. This is a way of removing the `(W := W)` hack introduced in #39124 .
|
Pull request successfully merged into master. Build succeeded: |
I noticed typeclass inference being slow to infer this input, so let's try making it explicit.
This is a way of removing the
(W := W)hack introduced in #39124 .