Skip to content

[Merged by Bors] - chore: rename {OpenPartialHomeomorph,PartialEquiv}.map_source''#40717

Closed
scholzhannah wants to merge 1 commit into
leanprover-community:masterfrom
scholzhannah:MapSource
Closed

[Merged by Bors] - chore: rename {OpenPartialHomeomorph,PartialEquiv}.map_source''#40717
scholzhannah wants to merge 1 commit into
leanprover-community:masterfrom
scholzhannah:MapSource

Conversation

@scholzhannah

@scholzhannah scholzhannah commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

The new name avoids a double prime and also matches the naming convention.
As suggested here.


Open in Gitpod

@github-actions

github-actions Bot commented Jun 17, 2026

Copy link
Copy Markdown

PR summary fa7579850d

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

++ image_source_subset
++-- map_source''

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit fa75798).

  • +2 new declarations
  • −0 removed declarations
+OpenPartialHomeomorph.image_source_subset
+PartialEquiv.image_source_subset

No changes to strong technical debt.

No changes to weak technical debt.

Current commit fa7579850d
Reference commit 3203991ba3

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@grunweg grunweg changed the title chore: rename map_source'' chore: rename {OpenPartialHomeomorph,PartialEquiv}.map_source'' Jun 17, 2026
@grunweg grunweg self-assigned this Jun 17, 2026
@grunweg grunweg added the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Jun 17, 2026
@grunweg

grunweg commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Thanks for doing this! I tweaked the title and PR description a bit, otherwise this looks good to me. Feel free to merge once CI passes!
bors d+

@mathlib-bors

mathlib-bors Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

✌️ scholzhannah can now approve this pull request until 2026-07-01 13:45 UTC (in 2 weeks). To approve and merge, reply with bors r+. More detailed instructions are available here.

⚠️ This delegation only covers changes within Archive/**, Counterexamples/**, docs/**, DownstreamTest/**, Mathlib/**, MathlibTest/**, widget/**, Archive.lean, Counterexamples.lean, docs.lean, Mathlib.lean; an author commit touching anything else will revoke it. Bors also revokes it if a later push changes too many files for it to check the full list — even if it stays within scope.

@mathlib-triage mathlib-triage Bot added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Jun 17, 2026
@github-actions github-actions Bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Jun 17, 2026
@scholzhannah

Copy link
Copy Markdown
Collaborator Author

bors r+

mathlib-bors Bot pushed a commit that referenced this pull request Jun 17, 2026
…0717)

The new name avoids a double prime and also matches the naming convention.
As suggested [here](#39084 (comment)).
@mathlib-bors

mathlib-bors Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title chore: rename {OpenPartialHomeomorph,PartialEquiv}.map_source'' [Merged by Bors] - chore: rename {OpenPartialHomeomorph,PartialEquiv}.map_source'' Jun 17, 2026
@mathlib-bors mathlib-bors Bot closed this Jun 17, 2026
xroblot pushed a commit to xroblot/mathlib4 that referenced this pull request Jun 18, 2026
…anprover-community#40717)

The new name avoids a double prime and also matches the naming convention.
As suggested [here](leanprover-community#39084 (comment)).
ReemMelamed pushed a commit to ReemMelamed/mathlib4 that referenced this pull request Jun 20, 2026
…anprover-community#40717)

The new name avoids a double prime and also matches the naming convention.
As suggested [here](leanprover-community#39084 (comment)).
bryangingechen pushed a commit to jcommelin/mathlib4 that referenced this pull request Jun 22, 2026
…anprover-community#40717)

The new name avoids a double prime and also matches the naming convention.
As suggested [here](leanprover-community#39084 (comment)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants