chore: simplify show _ from by _ to show _ by _#41493
Conversation
The term-mode `show t from e` elaborator and the `show t by tac` elaborator are both provided by the core `show` term syntax, so `show t from by tac` is exactly equivalent to the more direct `show t by tac`. This replaces all 20 occurrences of the former idiom with the latter across the library. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
PR summary b331e6c19fImport changes for modified filesNo significant changes to the import graph Import changes for all files
|
There was a problem hiding this comment.
A quick search that (I didnt read the description fully...)suffices foo from by also appears a couple of times, which culd also be shortened.
And I think you missed one occurence in Mathlib/Topology/Algebra/Monoid.lean (which goes over multiple lines, this is the only from by pattern doing that
`show t from by tac` split across two lines (`from` at end of one line, `by` at the start of the next) in `Topology/Algebra/Monoid.lean` was missed by the single-line search; convert it to `show t by tac` as well. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Thanks! I've added that change. |
|
I'll be happy to review the |
|
The diff so far LGTM; is there a reason this PR is still labelled |
show X from tprovesXusing the termt;show X by tacprovesXusing the tactictac.show X from by tacis thus a redundant lengthening ofshow X by tac.This replaces all 21 occurrences of
show _ from by _in the library withshow _ by _.(Note: there are also 10
suffices _ from by _occurrences -- should I change them in this PR too?)