Skip to content

[Merged by Bors] - perf(Positivity): filter with isProp in compareHyp#42014

Closed
JovanGerb wants to merge 1 commit into
leanprover-community:masterfrom
JovanGerb:Jovan-positivity-isProp
Closed

[Merged by Bors] - perf(Positivity): filter with isProp in compareHyp#42014
JovanGerb wants to merge 1 commit into
leanprover-community:masterfrom
JovanGerb:Jovan-positivity-isProp

Conversation

@JovanGerb

Copy link
Copy Markdown
Contributor

This PR adds a check in the assumption procedure of positivity so that it only considers hypotheses that are propositions (and not data).


Open in Gitpod

@JovanGerb

Copy link
Copy Markdown
Contributor Author

!radar

@JovanGerb JovanGerb changed the title perf(Positivity): filter with isProp in compareHyp and ` perf(Positivity): filter with isProp in compareHyp Jul 22, 2026
@leanprover-radar

leanprover-radar commented Jul 22, 2026

Copy link
Copy Markdown

Benchmark results for 3d09388 against 7d6261f are in. No significant results found. @JovanGerb

  • build//instructions: -157.4G (-0.11%)

Small changes (15✅)

  • build/module/Mathlib.Analysis.Analytic.Basic//instructions: -4.0G (-3.41%)
  • build/module/Mathlib.Analysis.Calculus.ContDiff.Bounds//instructions: -2.5G (-3.61%)
  • build/module/Mathlib.Analysis.Calculus.InverseFunctionTheorem.ApproximatesLinearOn//instructions: -1.8G (-5.10%)
  • build/module/Mathlib.Analysis.Convex.Jensen//instructions: -1.0G (-2.35%)
  • build/module/Mathlib.Analysis.Convex.Join//instructions: -1.5G (-8.07%)
  • build/module/Mathlib.Analysis.Convex.Visible//instructions: -1.6G (-5.32%)
  • build/module/Mathlib.Analysis.Distribution.SchwartzSpace.Basic//instructions: -5.0G (-2.86%)
  • build/module/Mathlib.Analysis.Fourier.FourierTransformDeriv//instructions: -3.4G (-2.45%)
  • build/module/Mathlib.Analysis.Normed.Lp.lpHolder//instructions: -2.7G (-4.07%)
  • build/module/Mathlib.Analysis.ODE.PicardLindelof//instructions: -1.7G (-4.79%)
  • build/module/Mathlib.Combinatorics.SimpleGraph.Regularity.Chunk//instructions: -2.5G (-3.24%)
  • build/module/Mathlib.Computability.AkraBazzi.AkraBazzi//instructions: -1.7G (-3.41%)
  • build/module/Mathlib.Computability.AkraBazzi.SumTransform//instructions: -2.7G (-4.53%)
  • build/module/Mathlib.Probability.CentralLimitTheorem//instructions: -1.5G (-6.00%)
  • and 1 hidden

@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown

PR summary 3d09388a78

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 3d09388).

  • +0 new declarations
  • −0 removed declarations

No declaration differences.


No changes to strong technical debt.

No changes to weak technical debt.

Current commit 3d09388a78
Reference commit 7d6261f2dc

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-meta Tactics, attributes or user commands label Jul 22, 2026
@b-mehta

b-mehta commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Thanks!

bors merge

@mathlib-bors mathlib-bors Bot added the ready-to-merge This PR has been sent to bors. label Jul 22, 2026
mathlib-bors Bot pushed a commit that referenced this pull request Jul 22, 2026
This PR adds a check in the assumption procedure of `positivity` so that it only considers hypotheses that are propositions (and not data).
@mathlib-bors mathlib-bors Bot added the bors-staging This PR is currently being built by bors on the staging branch. label Jul 22, 2026
@mathlib-bors

mathlib-bors Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

@mathlib-bors mathlib-bors Bot changed the title perf(Positivity): filter with isProp in compareHyp [Merged by Bors] - perf(Positivity): filter with isProp in compareHyp Jul 22, 2026
@mathlib-bors mathlib-bors Bot closed this Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bors-staging This PR is currently being built by bors on the staging branch. ready-to-merge This PR has been sent to bors. t-meta Tactics, attributes or user commands

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants