fix(NormNum): stop after a location closes the goal - #42355
fix(NormNum): stop after a location closes the goal#42355sankalpsthakur wants to merge 6 commits into
Conversation
Welcome new contributor!Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions. In particular, we kindly remind contributors that we have guidelines regarding the use of AI when making pull requests. We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the If you haven't already done so, please come to https://leanprover.zulipchat.com/, introduce yourself, and mention your new PR. Thank you again for joining our community. |
PR summary 3a7767a7e2Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
norm_num at h1 h2 ...(and other tactics built onLean.Elab.Tactic.withNondepPropLocation) unconditionally processed every hypothesis in the location list, then the target. If an earlier hypothesis closed the goal (e.g.norm_numfoundh1to already beFalse), processing continued against an already-closed goal instead of stopping.Stops iterating once
getGoalsis empty.Motivated by #28703.
Validation
lake build Mathlib.Util.AtLocationandlake build MathlibTest.Tactic.NormNum.Basic— both succeed, including the added regression test (h : 0 = 1, h2 : 0 = 2case).withNondepPropLocationcurrently has no other callers in the Mathlib tree besides its own definition file, so the change is narrowly scoped tonorm_num's own location handling. Did not run a full-library build; relying on CI for broader coverage.Closes #28703
AI/LLM disclosure
AI coding tools were used to help draft this change and PR description. I reviewed the complete change, understand the reasoning, and verified the build locally before submitting.