Skip to content

chore: golf (and rename) EuclideanDomain.to_principal_ideal_domain - #42359

Open
vihdzp wants to merge 4 commits into
leanprover-community:masterfrom
vihdzp:wf_golf
Open

chore: golf (and rename) EuclideanDomain.to_principal_ideal_domain#42359
vihdzp wants to merge 4 commits into
leanprover-community:masterfrom
vihdzp:wf_golf

Conversation

@vihdzp

@vihdzp vihdzp commented Aug 2, 2026

Copy link
Copy Markdown
Collaborator

Open in Gitpod

@github-actions

github-actions Bot commented Aug 2, 2026

Copy link
Copy Markdown

PR summary 22a7245776

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

+ EuclideanDomain.to_principal_ideal_domain
+ instance (priority := 100) EuclideanDomain.isPrincipalIdealRing : IsPrincipalIdealRing R
- instance (priority := 100) EuclideanDomain.to_principal_ideal_domain : IsPrincipalIdealRing R

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 22a7245).

  • +1 new declarations
  • −0 removed declarations
+EuclideanDomain.isPrincipalIdealRing

No changes to strong technical debt.

No changes to weak technical debt.

Current commit 22a7245776
Reference commit 80a3b5d919

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-ring-theory Ring theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant