Skip to content

chore(Order/Bounds/Basic): use to_dual more - #42362

Open
vihdzp wants to merge 1 commit into
leanprover-community:masterfrom
vihdzp:bounds
Open

chore(Order/Bounds/Basic): use to_dual more#42362
vihdzp wants to merge 1 commit into
leanprover-community:masterfrom
vihdzp:bounds

Conversation

@vihdzp

@vihdzp vihdzp commented Aug 2, 2026

Copy link
Copy Markdown
Collaborator

Haven't dualized the whole file yet, but this is one more easy chunk out of the way.

Open in Gitpod

@vihdzp
vihdzp requested a review from JovanGerb August 2, 2026 01:55
@vihdzp vihdzp added the t-order Order theory label Aug 2, 2026
@github-actions

github-actions Bot commented Aug 2, 2026

Copy link
Copy Markdown

PR summary bf45c4f97e

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

- bddAbove_Ioc
- bddBelow_Icc
- bddBelow_Ioc
- bddBelow_Ioo
- isGLB_Icc
- isGLB_Ico
- isLUB_Ico
- isLUB_Ioo
- isLeast_Icc
- isLeast_Ico
- lowerBounds_Icc
- lowerBounds_Ico
- upperBounds_Ico
- upperBounds_Ioo

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit bf45c4f).

  • +0 new declarations
  • −0 removed declarations

No declaration differences.


No changes to strong technical debt.

No changes to weak technical debt.

Current commit bf45c4f97e
Reference commit 80a3b5d919

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-order Order theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant